From 963df6f04ec4b4ed5e127f41e6aa9a2d8086aed3 Mon Sep 17 00:00:00 2001 From: "Peter H. Boling" Date: Mon, 14 Jul 2025 19:21:11 +0000 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=91=B7=20workflow=20cleanup?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/coverage.yml | 1 + .github/workflows/current.yml | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index e54ed48c..44b211c5 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -94,6 +94,7 @@ jobs: # Build will fail here if coverage upload fails # which will hopefully be noticed for the lack of code coverage comments - name: Upload coverage to CodeCov + if: ${{ !env.ACT }} uses: codecov/codecov-action@v5 with: use_oidc: true diff --git a/.github/workflows/current.yml b/.github/workflows/current.yml index a4fb64e6..38bb53f2 100644 --- a/.github/workflows/current.yml +++ b/.github/workflows/current.yml @@ -37,15 +37,15 @@ jobs: strategy: matrix: include: - # Ruby 3.4 - - ruby: "3.4" + # Ruby + - ruby: "ruby" appraisal_name: "r3" exec_cmd: "rake test" gemfile: "Appraisal.root" rubygems: latest bundler: latest - # truffleruby-24.1 + # truffleruby - ruby: "truffleruby" appraisal_name: "r3" exec_cmd: "rake test" @@ -53,7 +53,7 @@ jobs: rubygems: default bundler: default - # jruby-10.0 (targets Ruby 3.4 compatibility) + # jruby - ruby: "jruby" appraisal_name: "r3" exec_cmd: "rake test" @@ -75,7 +75,7 @@ jobs: bundler: ${{ matrix.bundler }} bundler-cache: false - # Raw `bundle` will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e. Appraisal.root) + # Raw `bundle` will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e., Appraisal.root) # We need to do this first to get appraisal installed. # NOTE: This does not use the main Gemfile at all. - name: Install Root Appraisal From 54d42c5e0146906378f38f029496bc8af410bdee Mon Sep 17 00:00:00 2001 From: "Peter H. Boling" Date: Mon, 14 Jul 2025 20:28:22 +0000 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=91=B7=20Removed=20HTML=20coverage=20?= =?UTF-8?q?output?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - https://github.com/codecov/feedback/discussions/726#discussioncomment-13756707 --- .github/workflows/coverage.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 44b211c5..a91a75cd 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -9,7 +9,8 @@ env: K_SOUP_COV_MIN_BRANCH: 85 K_SOUP_COV_MIN_LINE: 91 K_SOUP_COV_MIN_HARD: true - K_SOUP_COV_FORMATTERS: "html,xml,rcov,lcov,json,tty" + # Removed HTML output, see: https://github.com/codecov/feedback/discussions/726#discussioncomment-13756707 + K_SOUP_COV_FORMATTERS: "xml,rcov,lcov,json,tty" K_SOUP_COV_DO: true K_SOUP_COV_MULTI_FORMATTERS: true K_SOUP_COV_COMMAND_NAME: "Test Coverage" From 33796b32f1a025672e42488b897097a67cbbd7f5 Mon Sep 17 00:00:00 2001 From: "Peter H. Boling" Date: Mon, 14 Jul 2025 20:40:21 +0000 Subject: [PATCH 3/3] =?UTF-8?q?=E2=AC=86=EF=B8=8F=20Switch=20to=20appraisa?= =?UTF-8?q?l2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/coverage.yml | 1 + .idea/workspace.xml | 12 ++++++------ Appraisal.root.gemfile | 2 +- Gemfile | 2 +- Gemfile.lock | 23 ++++++++--------------- gemfiles/modular/coverage.gemfile | 3 --- 6 files changed, 17 insertions(+), 26 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index a91a75cd..babbd91d 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -6,6 +6,7 @@ permissions: id-token: write env: + COVERAGE: true K_SOUP_COV_MIN_BRANCH: 85 K_SOUP_COV_MIN_LINE: 91 K_SOUP_COV_MIN_HARD: true diff --git a/.idea/workspace.xml b/.idea/workspace.xml index dd5145b2..f3927d0d 100644 --- a/.idea/workspace.xml +++ b/.idea/workspace.xml @@ -5,12 +5,12 @@ + + + - - - - +