diff --git a/.github/workflows/danger-comment.yml b/.github/workflows/danger-comment.yml new file mode 100644 index 0000000..8eb900f --- /dev/null +++ b/.github/workflows/danger-comment.yml @@ -0,0 +1,10 @@ +name: Danger Comment +on: + workflow_run: + workflows: [Danger] + types: [completed] + +jobs: + comment: + uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@main + secrets: inherit diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 4d4e6ae..947f5ad 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,21 +1,11 @@ -name: danger -on: pull_request +name: Danger +on: + pull_request: + types: [opened, reopened, edited, synchronize] jobs: danger: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 100 - - name: Set up Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: 3.2 - bundler-cache: true - rubygems: latest - - name: Run Danger - run: | - # the token is public, has public_repo scope and belongs to the grape-bot user owned by @dblock, this is ok - TOKEN=$(echo -n Z2hwX2lYb0dPNXNyejYzOFJyaTV3QUxUdkNiS1dtblFwZTFuRXpmMwo= | base64 --decode) - DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose + uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@main + secrets: inherit + with: + ruby-version: "3.2" diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e05f25..3de23d7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ #### Fixes * Your contribution here. +* [#88](https://github.com/ruby-grape/grape-swagger-entity/pull/88): Update danger workflows - [@numbata](https://github.com/numbata). ### 0.7.0 (2025/08/02) diff --git a/Gemfile b/Gemfile index c5c4b7e..1718ad0 100644 --- a/Gemfile +++ b/Gemfile @@ -44,6 +44,6 @@ end group :test do gem 'grape-entity', grape_entity_spec - gem 'ruby-grape-danger', '~> 0.2.1', require: false + gem 'ruby-grape-danger', '~> 0.3.0', require: false gem 'simplecov', require: false end diff --git a/lib/grape-swagger/entity/parser.rb b/lib/grape-swagger/entity/parser.rb index 34c0b56..31443f0 100644 --- a/lib/grape-swagger/entity/parser.rb +++ b/lib/grape-swagger/entity/parser.rb @@ -111,7 +111,7 @@ def parse_nested(entity_name, entity_options, parent_model = nil) .map(&:nested_exposures) .flatten .each_with_object({}) do |value, memo| - memo[value.attribute] = value.send(:options) + memo[value.attribute] = value.send(:options) end properties, required = parse_grape_entity_params(params, nested_entities.last)