From 6f73d0b8d5c22da84eee551cc511c63dd9de8ede Mon Sep 17 00:00:00 2001 From: Mats Lidell Date: Mon, 23 Mar 2026 21:47:06 +0100 Subject: [PATCH 1/5] Use let for undefined free var ext * hibtypes.el (hib-link-to-file-line): Use let for undefined free var ext. Fix indentation. --- hibtypes.el | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hibtypes.el b/hibtypes.el index 84c87e83..c28f0a30 100644 --- a/hibtypes.el +++ b/hibtypes.el @@ -1027,15 +1027,16 @@ LINE-NUM may be an integer or string." ((stringp source-loc) (setq file (expand-file-name file (file-name-directory source-loc)))) (t (setq file (or (hpath:prepend-shell-directory file) - ;; find-library-name will strip file - ;; suffixes, so use it only when the file - ;; either doesn't have a suffix or has a - ;; library suffix. - (and (or (null (setq ext (file-name-extension file))) - (member (concat "." ext) (get-load-suffixes))) - (ignore-errors (find-library-name file))) - (hpath:is-p (expand-file-name file)) - (hywiki-get-existing-page-file file))))) + ;; find-library-name will strip file + ;; suffixes, so use it only when the file + ;; either doesn't have a suffix or has a + ;; library suffix. + (let ((ext (file-name-extension file))) + (when (or (null ext) + (member (concat "." ext) (get-load-suffixes))) + (ignore-errors (find-library-name file)))) + (hpath:is-p (expand-file-name file)) + (hywiki-get-existing-page-file file))))) (when (file-exists-p (hpath:normalize file)) (actypes::link-to-file-line file line-num)))) From db861b3367d414a5f5a925484613f1b560b0a0f0 Mon Sep 17 00:00:00 2001 From: Mats Lidell Date: Mon, 23 Mar 2026 21:48:58 +0100 Subject: [PATCH 2/5] Silence byte compilation warnings * hywiki.el (consult-grep-args, consult-ripgrep-args): Defvar consult variables. (hywiki-org-to-heading-instance): Use with-suppressed-warnings for obsolete org-show-entry. --- hywiki.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hywiki.el b/hywiki.el index 856f4d87..459a0e5a 100644 --- a/hywiki.el +++ b/hywiki.el @@ -159,6 +159,8 @@ (defvar action-key-modeline-buffer-id-function) ;; "hui-mouse.el" (defvar bookmark-current-bookmark) ;; "bookmark.el" +(defvar consult-grep-args) ;; "consult.el" +(defvar consult-ripgrep-args) ;; "consult.el" (defvar hkey-value) ;; "hui-mouse.el" (defvar hywiki-referent-menu nil) ;; "hywiki.el" (defvar org-agenda-buffer-tmp-name) ;; "org-agenda.el" @@ -3291,7 +3293,8 @@ If such an instance is not found, trigger an error." (goto-char found) ;; Ensure the heading is visible if folded (if (version< org-version "9.6") - (org-show-entry) + (with-suppressed-warnings ((obsolete org-show-entry)) + (org-show-entry)) (org-fold-show-entry)) ;; (message "Instance %d of '%s'" n title) t) From a8d2ea80b14a941eee5fc9e93dbcfe77447106c5 Mon Sep 17 00:00:00 2001 From: Mats Lidell Date: Tue, 24 Mar 2026 17:33:11 +0100 Subject: [PATCH 3/5] Remove warnings from smart-profiler-report * hui-mouse.el (profiler-report-find-entry) (profiler-report-toggle-entry): Declare functions. Sort the functions. (smart-profiler-report): Shorten docstring line below 80 chars. Do explicit initialization of curr-buffer since byte-compiler does not see it will be set. --- hui-mouse.el | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hui-mouse.el b/hui-mouse.el index 5e9ccd14..ba1e12fe 100644 --- a/hui-mouse.el +++ b/hui-mouse.el @@ -98,13 +98,15 @@ (declare-function kotl-mode:eolp "kotl-mode") ;; Emacs functions +(declare-function Custom-buffer-done "cus-edit") +(declare-function Custom-newline "cus-edit") +(declare-function outline-invisible-in-p "hyperbole") +(declare-function profiler-report-find-entry "profiler") +(declare-function profiler-report-toggle-entry "profiler") +(declare-function tar-expunge "tar") +(declare-function tar-extract-other-window "tar") (declare-function tar-flag-deleted "tar") (declare-function tar-unflag "tar") -(declare-function tar-extract-other-window "tar") -(declare-function tar-expunge "tar") -(declare-function outline-invisible-in-p "hyperbole") -(declare-function Custom-newline "cus-edit") -(declare-function Custom-buffer-done "cus-edit") ;;; ************************************************************************ ;;; Public variables @@ -2212,7 +2214,7 @@ caller has already checked that the key was pressed in an appropriate buffer and has moved the cursor there. If key is pressed: - (1) on the text of a linked call tree item, jumps to the definition of the item; + (1) on the text of a linked call tree item, jumps to the items definition; (2) on or after the last line in the buffer, quits from the profiler report." (interactive) (cond @@ -2221,7 +2223,7 @@ If key is pressed: (quit-window)) ;; If on the text of an entry, jump to its definition if is a link ((text-property-any (point) (1+ (point)) 'face 'link) - (let* ((curr-buffer) + (let* ((curr-buffer nil) (find-function-after-hook '((lambda () (setq curr-buffer (current-buffer)))))) (hpath:display-buffer (save-window-excursion From c11be290f9f9e0ce47337f95a3aebcbb03bf9b72 Mon Sep 17 00:00:00 2001 From: Mats Lidell Date: Tue, 24 Mar 2026 23:01:51 +0100 Subject: [PATCH 4/5] Add ChangeLog --- ChangeLog | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/ChangeLog b/ChangeLog index 3151612d..5633318c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2026-03-24 Mats Lidell + +* hui-mouse.el (profiler-report-find-entry) + (profiler-report-toggle-entry): Declare functions and sort the + declarations. + (smart-profiler-report): Shorten docstring line below 80 + chars. Do explicit initialization of curr-buffer since + byte-compiler does not see it will be set. + +* hywiki.el (consult-grep-args, consult-ripgrep-args): Defvar consult + variables. + (hywiki-org-to-heading-instance): Use with-suppressed-warnings for + obsolete org-show-entry. + +* hibtypes.el (hib-link-to-file-line): Use let for undefined free var + ext. Fix indentation. + 2026-03-23 Bob Weiner * hui-mouse.el (hkey-alist): Add 'profiler-report-mode' support for jumping From 3967abdd47276d87ebbe8e891d81ed1b33ca0a66 Mon Sep 17 00:00:00 2001 From: Mats Lidell Date: Wed, 25 Mar 2026 08:55:01 +0100 Subject: [PATCH 5/5] Revert "Use let for undefined free var ext" This reverts commit 6f73d0b8d5c22da84eee551cc511c63dd9de8ede. --- ChangeLog | 3 --- hibtypes.el | 19 +++++++++---------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5633318c..5947b195 100644 --- a/ChangeLog +++ b/ChangeLog @@ -12,9 +12,6 @@ (hywiki-org-to-heading-instance): Use with-suppressed-warnings for obsolete org-show-entry. -* hibtypes.el (hib-link-to-file-line): Use let for undefined free var - ext. Fix indentation. - 2026-03-23 Bob Weiner * hui-mouse.el (hkey-alist): Add 'profiler-report-mode' support for jumping diff --git a/hibtypes.el b/hibtypes.el index c28f0a30..84c87e83 100644 --- a/hibtypes.el +++ b/hibtypes.el @@ -1027,16 +1027,15 @@ LINE-NUM may be an integer or string." ((stringp source-loc) (setq file (expand-file-name file (file-name-directory source-loc)))) (t (setq file (or (hpath:prepend-shell-directory file) - ;; find-library-name will strip file - ;; suffixes, so use it only when the file - ;; either doesn't have a suffix or has a - ;; library suffix. - (let ((ext (file-name-extension file))) - (when (or (null ext) - (member (concat "." ext) (get-load-suffixes))) - (ignore-errors (find-library-name file)))) - (hpath:is-p (expand-file-name file)) - (hywiki-get-existing-page-file file))))) + ;; find-library-name will strip file + ;; suffixes, so use it only when the file + ;; either doesn't have a suffix or has a + ;; library suffix. + (and (or (null (setq ext (file-name-extension file))) + (member (concat "." ext) (get-load-suffixes))) + (ignore-errors (find-library-name file))) + (hpath:is-p (expand-file-name file)) + (hywiki-get-existing-page-file file))))) (when (file-exists-p (hpath:normalize file)) (actypes::link-to-file-line file line-num))))