Enable and fix AsyncParametersClientTest (osrf#51)

Now we're actually running the tests.

This also fixes a bug where we were comparing the wrong objects in one of the tests.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

Author: jacobperron

rcljava/CMakeLists.txt

@@ -270,8 +270,8 @@ if(BUILD_TESTING)
     "src/test/java/org/ros2/rcljava/node/NodeParametersTest.java"
     "src/test/java/org/ros2/rcljava/node/NodeUndeclaredParametersTest.java"
     "src/test/java/org/ros2/rcljava/node/NodeTest.java"
-    # "src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java"
-    # "src/test/java/org/ros2/rcljava/parameters/SyncParametersClientTest.java"
+    "src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java"
+    "src/test/java/org/ros2/rcljava/parameters/SyncParametersClientTest.java"
     "src/test/java/org/ros2/rcljava/publisher/PublisherTest.java"
     "src/test/java/org/ros2/rcljava/qos/QoSProfileTest.java"
     "src/test/java/org/ros2/rcljava/subscription/SubscriptionTest.java"
@@ -289,7 +289,8 @@ if(BUILD_TESTING)
     "org.ros2.rcljava.node.NodeParametersTest"
     "org.ros2.rcljava.node.NodeUndeclaredParametersTest"
     "org.ros2.rcljava.node.NodeTest"
-    # "org.ros2.rcljava.parameters.SyncParametersClientTest"
+    "org.ros2.rcljava.parameters.AsyncParametersClientTest"
+    "org.ros2.rcljava.parameters.SyncParametersClientTest"
     "org.ros2.rcljava.publisher.PublisherTest"
     "org.ros2.rcljava.qos.QoSProfileTest"
     "org.ros2.rcljava.subscription.SubscriptionTest"

rcljava/src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java

@@ -119,8 +119,14 @@ public final void testSetParameters() throws Exception {
     List<String> parameterNames =
         Arrays.asList(new String[] {"foo", "bar", "baz", "foo.first", "foo.second", "foobar"});
 
+    List<rcl_interfaces.msg.SetParametersResult> setParametersResults = future.get();
+    assertEquals(6, setParametersResults.size());
+    for (rcl_interfaces.msg.SetParametersResult result : setParametersResults) {
+      assertEquals(true, result.getSuccessful());
+    }
+
     List<ParameterVariant> results = node.getParameters(parameterNames);
-    assertEquals(parameters, future.get());
+    assertEquals(parameters, results);
   }
 
   @Test