From efd3c2d102b746d88747e88aefcb512a5266a1cc Mon Sep 17 00:00:00 2001 From: Jonas Rembser Date: Thu, 22 Jan 2026 17:32:15 +0100 Subject: [PATCH] [ci] Use C++20 also in the nightly build with `cmake_cxxmodules=OFF` This avoids surprises where fragile test failures with C++17 and modules=OFF cannot be anticipated from the PR builds. The test in question is in `test_datatypes.py` in the cppyy test suite: ```txt =================================== FAILURES =================================== ____________________ TestDATATYPES.test49_addressof_method _____________________ self = @mark.xfail(strict=True, condition=IS_MAC_ARM or IS_WINDOWS, reason="Crashes on mac-beta ARM64 and fails on Windows") def test49_addressof_method(self): """Use of addressof for (const) methods""" import cppyy > assert cppyy.addressof(cppyy.gbl.std.vector[int].at.__overload__(':any:', False)) E AssertionError: assert 0 E + where 0 = () E + where = .addressof E + and = (':any:', False) E + where = .__overload__ E + where = at 0x5628463dfb40>.at ../../../../../../src/bindings/pyroot/cppyy/cppyy/test/test_datatypes.py:2348: AssertionError ----------------------------- Captured stderr call ----------------------------- input_line_412:2:106: error: 'RActivePhysicalColumns' is a protected member of 'ROOT::Internal::RPageSource' (vector::reference (std::vector >::*)(vector::size_type))&std::vector >::at ^ /github/home/ROOT-CI/build/include/ROOT/RPageStorage.hxx:653:10: note: declared protected here class RActivePhysicalColumns { ^ =========================== short test summary info ============================ ``` --- .../workflows/root-ci-config/buildconfig/alma9-modules_off.txt | 1 + .github/workflows/root-ci.yml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/root-ci-config/buildconfig/alma9-modules_off.txt b/.github/workflows/root-ci-config/buildconfig/alma9-modules_off.txt index 6a5a834c3f425..49a308c04a656 100644 --- a/.github/workflows/root-ci-config/buildconfig/alma9-modules_off.txt +++ b/.github/workflows/root-ci-config/buildconfig/alma9-modules_off.txt @@ -1,3 +1,4 @@ +CMAKE_CXX_STANDARD=20 builtin_vdt=ON pythia8=ON runtime_cxxmodules=OFF diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index a0638cec307bd..42c8e4dab9b62 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -403,7 +403,6 @@ jobs: platform_config: alma9-modules_off is_special: true property: modules_off - overrides: ["CMAKE_CXX_STANDARD=20"] - image: alma9 platform_config: alma9-march_native is_special: true