Refactor kickoff.ps1 for improved module installation

Author: rolling-code

generic/kickoff.ps1

@@ -1,4 +1,4 @@
-Set-Location "C:\Users\something that works for you"
+Set-Location "C:\Users\cyberadmin\Desktop"
 
 # Determine PSVersion once
 $pv = $PSVersionTable.PSVersion
@@ -16,79 +16,57 @@ Function Start-MyCommands {
     }
     #Safer execution policy for user scope
     Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned -Force
+	
+	Write-Host "⚡Installing ...RSAT-AD-PowerShell" -ForegroundColor Green
+	Install-WindowsFeature -Name RSAT-AD-PowerShell
 
-    #Update PowerShellGet / PackageManagement to avoid missing parameter issues
-    try {
-        Install-Module -Name PowerShellGet -Force -Scope CurrentUser -ErrorAction Continue
-    } catch {
-        #Write-Verbose "⚡PowerShellGet update skipped: $($_.Exception.Message)" -ForegroundColor Green 
-		Write-Host ("⚡PowerShellGet update skipped: {0}" -f $_.Exception.Message) -ForegroundColor Green
-    }
-    try {
-        Install-Module -Name PackageManagement -Force -Scope CurrentUser -ErrorAction Continue
-    } catch {
-        #Write-Verbose "⚡PackageManagement update skipped: $($_.Exception.Message)" -ForegroundColor Yellow
-		Write-Host ("⚡PackageManagement update skipped: {0}" -f $_.Exception.Message) -ForegroundColor Yellow
-    }
+	Write-Host "⚡Installing ...NuGet provider" -ForegroundColor Green 
+	Install-PackageProvider -Name NuGet -Force -Scope AllUsers
 
-    Write-Host "⚡Ensuring AADInternals and AADInternals-Endpoints present and up to date..." -ForegroundColor Green
-    $modules =  @('AADInternals', 'AADInternals-Endpoints')
-	foreach($m in $modules) {
-		$installed = Get-InstalledModule -Name $m -ErrorAction Continue
-		if (-not $installed) {
-			Write-Host "⚡Installing $m" -ForegroundColor Green
-			Install-Module -Name $m -Scope CurrentUser -Force -ErrorAction Continue
-		} else {
-			$remote = Find-Module -Name $m -ErrorAction Continue
-			if ($remote -and ($remote.Version -gt $installed.Version)) {
-				Write-Host "⚡Updating $m (local $($installed.Version) -> remote $($remote.Version))" -ForegroundColor Green
-				Update-Module -Name $m -Force -ErrorAction Continue
-			} else {
-				Write-Host "⚡$m is up to date" -ForegroundColor Green
-			}
-		}
-		Import-Module -Name $m -ErrorAction Continue
-    }
-	# install the AD GUI+tools capability (includes ADUC)
+	Write-Host "⚡Installing ...PowerShellGet" -ForegroundColor Green
+	Install-Module -Name PowerShellGet -Force -Scope AllUsers
+	
+	Write-Host "⚡Installing ...PackageManagement" -ForegroundColor Green
+	Install-Module -Name PackageManagement -Force -Scope AllUsers -AllowClobber
+
+    Write-Host "⚡Installing ...AADInternals" -ForegroundColor Green
+	Install-Module -Name AADInternals -Scope AllUsers -Force -AllowClobber
+	
+	Write-Host "⚡Installing ...AADInternals-Endpoints" -ForegroundColor Green
+	Install-Module -Name 'AADInternals-Endpoints' -Scope AllUsers -Force -AllowClobber
+	
+	Write-Host "⚡Importing ...AADInternals" -ForegroundColor Green
+	Import-Module AADInternals
+	
+	Write-Host "⚡Importing ...AADInternals-Endpoints" -ForegroundColor Green
+	Import-Module 'AADInternals-Endpoints'
+
+	Write-Host "⚡Add-WindowsCapability ...Rsat.ActiveDirectory" -ForegroundColor Green
 	Add-WindowsCapability -Online -Name Rsat.ActiveDirectory.DS-LDS.Tools~~~~0.0.1.0
 
-	# install the AD PowerShell module (if separate on your build)
+	Write-Host "⚡Add-WindowsCapability ...Rsat.AD" -ForegroundColor Green
 	Add-WindowsCapability -Online -Name Rsat.AD.PowerShell~~~~0.0.1.0
 
-	# load the module into the current session
+	Write-Host "⚡Importing ...ActiveDirectory" -ForegroundColor Green
 	Import-Module ActiveDirectory
 
-
     Write-Host "⚡Listing Active Directory Module part of RSAT..." -ForegroundColor Green
     Get-Module ActiveDirectory -ListAvailable
+	
     Write-Host "⚡Showing RSAT version..." -ForegroundColor Green
     Get-WindowsCapability -Name 'RSAT.ActiveDirectory*' -Online
+	
+	Write-Host "⚡Installing ...Az" -ForegroundColor Green
+	Install-Module -Name Az -Scope AllUsers -AllowClobber -Force
 
     Write-Host "⚡Showing Azure PowerShell version..." -ForegroundColor Green
     Get-InstalledModule -Name Az | Format-Table -AutoSize
     Start-Sleep -Seconds 2
 
-    Write-Host "⚡Installing or updating DSInternals..." -ForegroundColor Green
-    if (-not(Get-InstalledModule -Name DSInternals -ErrorAction Continue)) {
-        Install-Module -Name DSInternals -Scope CurrentUser -Force -ErrorAction Continue
-    } else {
-        $local = Get-InstalledModule -Name DSInternals
-        $remote = Find-Module -Name DSInternals -ErrorAction Continue
-        if ($remote -and($remote.Version -gt $local.Version)) {
-            Update-Module -Name DSInternals -Force -ErrorAction Continue
-        }
-    }
-    #Wait for availability with timeout
-    $timeout = 30;
-    $elapsed = 0
-	while (-not(Get-Module -Name DSInternals -ListAvailable) -and($elapsed -lt $timeout)) {
-		Write-Host "⚡Waiting for DSInternals to become available..." -ForegroundColor Yellow
-		Start-Sleep -Seconds 2;
-		$elapsed += 2
-	}
-    if ($elapsed -ge $timeout) {
-        Write-Warning "⚡Timeout waiting for DSInternals module" -ForegroundColor Yellow
-    }
+    Write-Host "⚡Installing ...DSInternals" -ForegroundColor Green
+	Install-Module -Name DSInternals -Scope AllUsers -AllowClobber -Force
+	
+	Write-Host "⚡Importing ...DSInternals" -ForegroundColor Green
     Import-Module -Name DSInternals -ErrorAction Continue
 
 	if ($pv.Major -ge 7) {
@@ -109,7 +87,6 @@ Function Start-MyCommands {
 			Import-Module -Name $psReflectPath -ErrorAction Continue
 			Write-Host "⚡PSReflect loaded from $psReflectPath" -ForegroundColor Green
 		} else {
-			#Write-Warning "⚡PSReflect module not found at $psReflectPath" -ForegroundColor Yellow
 			Write-Host ("⚡PSReflect module not found at: {0}" -f $psReflectPath) -ForegroundColor Yellow
 		}
 
@@ -119,7 +96,6 @@ Function Start-MyCommands {
 			.$powerViewPath #dot - source a script to import functions into session 
 			Write-Host "⚡PowerView dot-sourced from $powerViewPath" -ForegroundColor Green
 		} else {
-			#Write-Warning "⚡PowerView not found at $powerViewPath" -ForegroundColor Yellow
 			Write-Host ("⚡PowerView module not found at: {0}" -f $powerViewPath) -ForegroundColor Yellow
 		}
 	}else{
@@ -130,6 +106,7 @@ Function Start-MyCommands {
 
 	Write-Host "⚡Installing PSPreworkout" -ForegroundColor Green
 	Install-Module -Name PSPreworkout -Scope CurrentUser -Force -AllowClobber
+	
 	Write-Host "⚡Checking for updates" -ForegroundColor Green
 	Get-ModulesWithUpdate -PassThru
 
@@ -147,11 +124,14 @@ Function Start-MyCommands {
 		}
 	}
 
-	Write-Host "⚡Installing Azure Automation CLI extension" -ForegroundColor Green
-	az extension add -n automation
-	
-	Write-Host "⚡Enables automatic, silent installation of missing CLI extensions when you run a command for the first time" -ForegroundColor Green
-	az config set extension.use_dynamic_install=yes_without_prompt
+	if (Get-Command az -ErrorAction SilentlyContinue) {
+		Write-Host "⚡Installing Azure Automation CLI extension" -ForegroundColor Green
+		az extension add -n automation
+		Write-Host "⚡Enables automatic, silent installation of missing CLI extensions when you run a command for the first time" -ForegroundColor Green
+		az config set extension.use_dynamic_install=yes_without_prompt
+	} else {
+		Write-Host "Azure CLI (az) not found; skipping az extension commands" -ForegroundColor Yellow
+	}
 
     Write-Host "⚡PowerView Runs much better in an older PS - RUN the following..." -ForegroundColor Green
     Write-Host "⚡powershell.exe -Version 5.1" -ForegroundColor Green
@@ -164,4 +144,3 @@ Function Start-MyCommands {
 Start-MyCommands
 
 Get-Module -Name AADInternals, AADInternals-Endpoints, DSInternals, ActiveDirectory, PSPreworkout, PSReflect, PowerView -ErrorAction SilentlyContinue
-