Visibility: require all root config before preloading#5635
Merged
Conversation
rmosolgo
commented
May 21, 2026
| wrapped_object = @object_class.wrap(obj, query_ctx) | ||
| @inner_resolve.call(wrapped_object, args, ctx) | ||
| end | ||
| end |
Owner
Author
There was a problem hiding this comment.
Wow, I think this was very old!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
If you're using Rails and have
use GraphQL::Schema::Visibilitybefore configuring your root types,this will raise an error at application boot.
Fix the error by moving
use ...below that configuration.Your app will boot faster every time after that!
Fixes #5454
GraphQL::Schema::Visibility didn't handle it right when root-level configurations came after
use ... preload: true. It tried to, but profiles still weren't actually preloaded correctly.When configuration is inherited, it has to fall back to rebuilding the visibility cache dynamically. This is slower than the new behavior ... but it's also how it used to always work. It can be avoided by removing
use ...from the parent class and putting it in child classes only.