refactor: Consolidate naming, rendering, syntax, deps, and uploader changes

- Renamed and refactored version identifiers
- Fixed diagram rendering logic
- Updated NPM dependencies
- Adjusted uploader implementation

GitOrigin-RevId: 2fef07cfe809d32ae3a0e09a65d14df08b3c125a

Author: richyo-codes

.github/workflows/ci.yml

@@ -129,6 +129,7 @@ jobs:
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_MAKE_PROGRAM=ninja
           -DPULSECAN_USE_VCPKG=OFF
+          -DPULSECAN_BUILD_ID="${GIT_DESCRIBE}"
           -DBUILD_TESTING=OFF
           -DCMAKE_C_COMPILER=gcc
           -DCMAKE_CXX_COMPILER=g++
@@ -139,12 +140,6 @@ jobs:
       - name: Package (RPM)
         run: cpack --config build/CPackConfig.cmake -G RPM -B build/packages
 
-      - name: Rename RPM with git version (system)
-        run: |
-          for f in build/packages/*.rpm; do
-            mv "$f" "build/packages/pulsescan-${GIT_DESCRIBE}-system.rpm"
-          done
-
       - name: Show RPM size (system)
         run: |
           ls -lh build/packages/*.rpm
@@ -194,6 +189,7 @@ jobs:
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_MAKE_PROGRAM=ninja
           -DPULSECAN_USE_VCPKG=ON
+          -DPULSECAN_BUILD_ID="${GIT_DESCRIBE}"
           -DCMAKE_TOOLCHAIN_FILE="${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
           -DBUILD_TESTING=OFF
           -DCMAKE_C_COMPILER=gcc
@@ -205,12 +201,6 @@ jobs:
       - name: Package (RPM static)
         run: cpack --config build/CPackConfig.cmake -G RPM -B build/packages
 
-      - name: Rename RPM with git version (static)
-        run: |
-          for f in build/packages/*.rpm; do
-            mv "$f" "build/packages/pulsescan-${GIT_DESCRIBE}-static.rpm"
-          done
-
       - name: Show RPM size (static)
         run: |
           ls -lh build/packages/*.rpm
@@ -253,6 +243,7 @@ jobs:
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_MAKE_PROGRAM=ninja
           -DPULSECAN_USE_VCPKG=OFF
+          -DPULSECAN_BUILD_ID="${GIT_DESCRIBE}"
           -DBUILD_TESTING=OFF
           -DCMAKE_C_COMPILER=gcc
           -DCMAKE_CXX_COMPILER=g++
@@ -263,12 +254,6 @@ jobs:
       - name: Package (DEB)
         run: cpack --config build/CPackConfig.cmake -G DEB -B build/packages
 
-      - name: Rename DEB with git version (system)
-        run: |
-          for f in build/packages/*.deb; do
-            mv "$f" "build/packages/pulsescan-${GIT_DESCRIBE}-system.deb"
-          done
-
       - name: Show DEB size (system)
         run: |
           ls -lh build/packages/*.deb
@@ -316,6 +301,7 @@ jobs:
           -DCMAKE_BUILD_TYPE=Release
           -DCMAKE_MAKE_PROGRAM=ninja
           -DPULSECAN_USE_VCPKG=ON
+          -DPULSECAN_BUILD_ID="${GIT_DESCRIBE}"
           -DCMAKE_TOOLCHAIN_FILE="${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
           -DBUILD_TESTING=OFF
           -DCMAKE_C_COMPILER=gcc
@@ -327,12 +313,6 @@ jobs:
       - name: Package (DEB static)
         run: cpack --config build/CPackConfig.cmake -G DEB -B build/packages
 
-      - name: Rename DEB with git version (static)
-        run: |
-          for f in build/packages/*.deb; do
-            mv "$f" "build/packages/pulsescan-${GIT_DESCRIBE}-static.deb"
-          done
-
       - name: Show DEB size (static)
         run: |
           ls -lh build/packages/*.deb

.github/workflows/diagrams.yml

@@ -23,14 +23,31 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: "20"
+          node-version: "24"
+
+      - name: Install Mermaid CLI dependency
+        run: npm install
+
+      - name: Install Chromium
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y chromium-browser || sudo apt-get install -y chromium
+
+      - name: Resolve Chromium path
+        run: |
+          CHROME_PATH="$(command -v chromium-browser || command -v chromium || command -v google-chrome-stable || command -v google-chrome)"
+          if [ -z "${CHROME_PATH}" ]; then
+            echo "Could not find Chromium/Chrome executable in PATH" >&2
+            exit 1
+          fi
+          echo "MERMAID_CHROME_PATH=${CHROME_PATH}" >> "${GITHUB_ENV}"
+          echo "Using MERMAID_CHROME_PATH=${CHROME_PATH}"
 
       - name: Render Mermaid diagrams
         run: ./scripts/render_diagrams.sh
 
       - name: Upload rendered diagrams
-        uses: actions/upload-artifact@v4
+        uses: richnetdesign/git-artifact-upload@v1
         with:
           name: diagrams-svg
           path: docs/diagrams/rendered/*.svg
-

.gitignore

@@ -42,4 +42,17 @@
 
 
 /build
-/.cache
+/.cache
+
+# Node docs tooling
+/node_modules/
+
+# Bazel outputs
+/bazel-bin/
+/bazel-out/
+/bazel-testlogs/
+/bazel-*/
+/MODULE.bazel.lock
+
+# Rendered Mermaid artifacts (source .mmd files are tracked)
+/docs/diagrams/rendered/*.svg

CMakeLists.txt

@@ -23,6 +23,7 @@ project(pulsescan_cpp VERSION 1.0.0 LANGUAGES CXX)
 option(ENABLE_STACKTRACE "Enable Boost stacktrace logging" OFF)
 option(ENABLE_ASIO_SSL "Enable Boost.Asio SSL support" OFF)
 option(ENABLE_INTEGRATION_TESTS "Enable environment-dependent integration tests" OFF)
+set(PULSECAN_BUILD_ID "" CACHE STRING "Optional CI build identifier (e.g. git describe)")
 
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
@@ -171,16 +172,28 @@ set(CPACK_PACKAGE_VENDOR "ryoung")
 set(CPACK_PACKAGE_CONTACT "ryoung")
 set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "PulseScan C++ network scanner and host monitor")
 set(CPACK_PACKAGE_DESCRIPTION "PulseScan C++ is an asynchronous network scanner supporting TCP connect, banner, UDP probing, and ICMP host checks with optional JSON output.")
-set(CPACK_PACKAGE_VERSION ${PROJECT_VERSION})
+set(PULSECAN_BUILD_ID_SANITIZED "${PULSECAN_BUILD_ID}")
+if(PULSECAN_BUILD_ID_SANITIZED)
+  string(REGEX REPLACE "[^A-Za-z0-9.+~]" "." PULSECAN_BUILD_ID_SANITIZED "${PULSECAN_BUILD_ID_SANITIZED}")
+endif()
+set(CPACK_PACKAGE_VERSION "${PROJECT_VERSION}")
 set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")
 set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS ON)
 set(CPACK_DEBIAN_PACKAGE_MAINTAINER "ryoung")
 set(CPACK_DEBIAN_PACKAGE_DESCRIPTION "${CPACK_PACKAGE_DESCRIPTION}")
 set(CPACK_DEBIAN_PACKAGE_SECTION "net")
 set(CPACK_DEBIAN_PACKAGE_HOMEPAGE "https://github.com/richnetdesign/port-scanner-cpp")
+set(CPACK_DEBIAN_FILE_NAME DEB-DEFAULT)
+if(PULSECAN_BUILD_ID_SANITIZED)
+  set(CPACK_DEBIAN_PACKAGE_RELEASE "1.${PULSECAN_BUILD_ID_SANITIZED}")
+endif()
 set(CPACK_RPM_PACKAGE_AUTOREQPROV ON)
 set(CPACK_RPM_PACKAGE_LICENSE "GPL-3.0-only")
 set(CPACK_RPM_PACKAGE_GROUP "Applications/Internet")
 set(CPACK_RPM_PACKAGE_DESCRIPTION "${CPACK_PACKAGE_DESCRIPTION}")
+set(CPACK_RPM_FILE_NAME RPM-DEFAULT)
+if(PULSECAN_BUILD_ID_SANITIZED)
+  set(CPACK_RPM_PACKAGE_RELEASE "1.${PULSECAN_BUILD_ID_SANITIZED}")
+endif()
 set(CPACK_GENERATOR "DEB;RPM")
 include(CPack)

docs/diagrams/ping_loop.mmd

@@ -1,26 +1,25 @@
 sequenceDiagram
     participant App as run_app
-    participant Loop as ping_loop (core/ping_loop.cpp)
+    participant PingLoop as ping_loop (core/ping_loop.cpp)
     participant Resolve as resolve_or_expand
     participant Runner as run_scans
     participant State as last_state map
     participant Out as emit_port_result / emit_unavailable
 
-    App->>Loop: ping_loop(hosts, opts, status)
+    App->>PingLoop: ping_loop(hosts, opts, status)
     loop every opts.ping_interval
-        Loop->>Resolve: resolve targets for current cycle
-        Resolve-->>Loop: addresses
-        Loop->>Runner: run_scans(..., callback)
-        Runner-->>Loop: ScanRecord stream
-        Loop->>State: compare current state vs previous
+        PingLoop->>Resolve: resolve targets for current cycle
+        Resolve-->>PingLoop: addresses
+        PingLoop->>Runner: run_scans(..., callback)
+        Runner-->>PingLoop: ScanRecord stream
+        PingLoop->>State: compare current state vs previous
         alt first pass or changed
-            Loop->>Out: emit_port_result(change=true/first)
+            PingLoop->>Out: emit_port_result(change=true/first)
         else unchanged
-            Note over Loop: No text output; JSON depends on filters
+            Note over PingLoop: No text output, JSON depends on filters
         end
-        Loop->>State: prune missing keys
+        PingLoop->>State: prune missing keys
         alt key disappeared
-            Loop->>Out: emit_unavailable(...)
+            PingLoop->>Out: emit_unavailable(...)
         end
     end
-