From 9f63c61a8080782c400851cffb2e2b9729677c16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Roland?= Date: Thu, 26 Dec 2024 12:19:41 +0100 Subject: [PATCH 1/2] fix: implement handle_info/2 --- lib/nodejs/worker.ex | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/nodejs/worker.ex b/lib/nodejs/worker.ex index 14474af..2a5f774 100644 --- a/lib/nodejs/worker.ex +++ b/lib/nodejs/worker.ex @@ -123,6 +123,15 @@ defmodule NodeJS.Worker do end end + def handle_info({_pid, data}, state) do + with :dev <- Mix.env(), + {_, {:eol, msg}} <- data do + IO.puts("NodeJS: #{msg}") + end + + {:noreply, state} + end + defp decode(data) do data |> to_string() From 42b3c81d9e8f68ac87d2ddbab8d5366c81ec8b24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Roland?= Date: Tue, 7 Jan 2025 18:40:01 +0100 Subject: [PATCH 2/2] fix: use logger and guard agaisnt mix.env in release --- lib/nodejs/worker.ex | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/nodejs/worker.ex b/lib/nodejs/worker.ex index 2a5f774..cb8dc40 100644 --- a/lib/nodejs/worker.ex +++ b/lib/nodejs/worker.ex @@ -12,6 +12,7 @@ defmodule NodeJS.Worker do @moduledoc """ A genserver that controls the starting of the node service """ + require Logger @doc """ Starts the Supervisor and underlying node service. @@ -123,10 +124,16 @@ defmodule NodeJS.Worker do end end + defp env do + Mix.env() + rescue + _ -> :release + end + def handle_info({_pid, data}, state) do - with :dev <- Mix.env(), + with :dev <- env(), {_, {:eol, msg}} <- data do - IO.puts("NodeJS: #{msg}") + Logger.info("NodeJS: #{msg}") end {:noreply, state}