fix: mismatched_lifetime_syntaxes & clippy compiler warnings (#584)

Fix various lints from Clippy, from the latest Rust version.

Author: replydev

src/interface/handlers/main_window.rs

@@ -123,20 +123,19 @@ pub(super) fn main_handler(key_event: KeyEvent, app: &mut App) {
 }
 
 fn handle_counter_switch(app: &mut App, increment: bool) {
-    if let Some(selected) = app.table.state.selected() {
-        if let Some(element) = app.database.mut_element(selected) {
-            if element.type_ == OTPType::Hotp {
-                // safe to unwrap because the element type is HOTP
-                let counter = element.counter.unwrap();
-                element.counter = if increment {
-                    Some(counter.checked_add(1).unwrap_or(u64::MAX))
-                } else {
-                    Some(counter.saturating_sub(1))
-                };
-                app.database.mark_modified();
-                app.tick(true);
-            }
-        }
+    if let Some(selected) = app.table.state.selected()
+        && let Some(element) = app.database.mut_element(selected)
+        && element.type_ == OTPType::Hotp
+    {
+        // safe to unwrap because the element type is HOTP
+        let counter = element.counter.unwrap();
+        element.counter = if increment {
+            Some(counter.saturating_add(1))
+        } else {
+            Some(counter.saturating_sub(1))
+        };
+        app.database.mark_modified();
+        app.tick(true);
     }
 }
 

src/interface/row.rs

@@ -21,7 +21,7 @@ impl Row {
             + 1) as u16
     }
 
-    pub fn cells(&self) -> Vec<Cell> {
+    pub fn cells(&self) -> Vec<Cell<'_>> {
         self.values
             .iter()
             .map(|c| {

src/path.rs

@@ -38,14 +38,13 @@ fn get_default_db_path() -> PathBuf {
     data_dir()
         .map(|p| p.join(XDG_PATH))
         .inspect(|xdg| {
-            if !xdg.exists() {
-                if let Some(home) = &home_path {
-                    if home.exists() {
-                        fs::create_dir_all(xdg.parent().unwrap()).expect("Failed to create dir");
-                        fs::copy(home, xdg.as_path())
-                            .expect("Failed on copy from legacy dir to XDG_DATA_HOME");
-                    }
-                }
+            if !xdg.exists()
+                && let Some(home) = &home_path
+                && home.exists()
+            {
+                fs::create_dir_all(xdg.parent().unwrap()).expect("Failed to create dir");
+                fs::copy(home, xdg.as_path())
+                    .expect("Failed on copy from legacy dir to XDG_DATA_HOME");
             }
         })
         .or(home_path)