Decode OTP Uri before parsing (#551)

Fixes an issue #548 on issuer and label parsing.

Author: replydev

src/otp/from_otp_uri.rs

@@ -9,7 +9,8 @@ pub trait FromOtpUri: Sized {
 
 impl FromOtpUri for OTPElement {
     fn from_otp_uri(otp_uri: &str) -> color_eyre::Result<Self> {
-        let parsed_uri = Url::parse(otp_uri).map_err(ErrReport::from)?;
+        let decoded = urlencoding::decode(otp_uri).map_err(ErrReport::from)?;
+        let parsed_uri = Url::parse(&decoded).map_err(ErrReport::from)?;
 
         let otp_type = parsed_uri
             .host_str()

src/otp/otp_element.rs

@@ -423,4 +423,34 @@ mod test {
             result.unwrap_err().to_string()
         );
     }
+
+    #[test]
+    fn gh_issue_548_invalid_otp_uri_label_url_encoded() {
+        // Arrange
+        let otp_uri = "otpauth://totp/foo%3abar?issuer=foo&secret=JBSWY3DPEHPK3PXP";
+
+        // Act
+        let result = OTPElement::from_otp_uri(otp_uri);
+
+        // Assert
+        assert!(result.is_ok());
+        let actual = result.unwrap();
+        assert_eq!("foo", actual.issuer.as_str());
+        assert_eq!("bar", actual.label.as_str());
+    }
+
+    #[test]
+    fn gh_issue_548_invalid_otp_uri_label_non_url_encoded() {
+        // Arrange
+        let otp_uri = "otpauth://totp/foo:bar?issuer=foo&secret=JBSWY3DPEHPK3PXP";
+
+        // Act
+        let result = OTPElement::from_otp_uri(otp_uri);
+
+        // Assert
+        assert!(result.is_ok());
+        let actual = result.unwrap();
+        assert_eq!("foo", actual.issuer.as_str());
+        assert_eq!("bar", actual.label.as_str());
+    }
 }