Unable to compile PascalScript_Core_D26.dpk for Linux64/MacOS64

[jdavison-mo]

I have latest revision with patches from issue #202 (commit 86a057c) but I am unable to compile the files that are part of the PascalScript_Core_D26.dpk for that platform for Linux64 nor MacOS64.

Here's some compiler output using Delphi 10.3.2 Rio dccosx64 compiler (similar results exist for dcclinux64):

[dcc] ./PascalScript_Core_D26.dpk
[dcc] ./uPSUtils.pas (730)
[dcc] Error: E2008 Incompatible types
[dcc] ./uPSCompiler.pas (1374)
[dcc] Fatal: F2063 Could not compile used unit 'uPSUtils.pas'

If I comment out that offending code then I get the following which is starting to look non-trivial...

[dcc] ./PascalScript_Core_D26.dpk
[dcc] ./uPSRuntime.pas (8923)
[dcc] Warning: W1057 Implicit string cast from 'AnsiString' to 'string'
[dcc] ./uPSRuntime.pas (11640)
[dcc] Error: E1025 Unsupported language feature: 'ASM'
[dcc] ./uPSRuntime.pas (11640)
[dcc] Error: E2029 ';' expected but 'ASM' found
[dcc] ./uPSRuntime.pas (11640)
[dcc] Warning: W1011 Text after final 'END.' - ignored by compiler
[dcc] ./uPSRuntime.pas (58)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSProcRec.Create'
[dcc] ./uPSRuntime.pas (60)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSProcRec.Destroy'
[dcc] ./uPSRuntime.pas (106)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSInternalProcRec.Destroy'
[dcc] ./uPSRuntime.pas (163)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSTypeRec_ProcPtr.CalcSize'
[dcc] ./uPSRuntime.pas (191)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSTypeRec_Array.CalcSize'
[dcc] ./uPSRuntime.pas (203)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSTypeRec_StaticArray.CalcSize'
[dcc] ./uPSRuntime.pas (214)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSTypeRec_Set.CalcSize'
[dcc] ./uPSRuntime.pas (535)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.GetValue'
[dcc] ./uPSRuntime.pas (536)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.GetValueCount'
[dcc] ./uPSRuntime.pas (549)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.AddValue'
[dcc] ./uPSRuntime.pas (551)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.DeleteValue'
[dcc] ./uPSRuntime.pas (553)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.AdjustSize'
[dcc] ./uPSRuntime.pas (556)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.Create'
[dcc] ./uPSRuntime.pas (558)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttribute.Destroy'
[dcc] ./uPSRuntime.pas (565)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.GetCount'
[dcc] ./uPSRuntime.pas (566)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.GetItem'
[dcc] ./uPSRuntime.pas (575)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.Delete'
[dcc] ./uPSRuntime.pas (577)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.Add'
[dcc] ./uPSRuntime.pas (579)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.FindAttribute'
[dcc] ./uPSRuntime.pas (582)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.Create'
[dcc] ./uPSRuntime.pas (584)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeAttributes.Destroy'
[dcc] ./uPSRuntime.pas (759)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSExec.RegisterDelphiFunction'
[dcc] ./uPSRuntime.pas (761)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSExec.RegisterDelphiMethod'
[dcc] ./uPSRuntime.pas (803)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetItem'
[dcc] ./uPSRuntime.pas (804)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetCapacity'
[dcc] ./uPSRuntime.pas (805)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.AdjustLength'
[dcc] ./uPSRuntime.pas (815)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.Create'
[dcc] ./uPSRuntime.pas (817)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.Destroy'
[dcc] ./uPSRuntime.pas (819)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.Clear'
[dcc] ./uPSRuntime.pas (821)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.Push'
[dcc] ./uPSRuntime.pas (823)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.PushType'
[dcc] ./uPSRuntime.pas (825)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.Pop'
[dcc] ./uPSRuntime.pas (826)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetInt'
[dcc] ./uPSRuntime.pas (827)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetUInt'
[dcc] ./uPSRuntime.pas (829)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetInt64'
[dcc] ./uPSRuntime.pas (831)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetString'
[dcc] ./uPSRuntime.pas (832)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetAnsiString'
[dcc] ./uPSRuntime.pas (834)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetWideString'
[dcc] ./uPSRuntime.pas (835)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetUnicodeString'
[dcc] ./uPSRuntime.pas (837)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetReal'
[dcc] ./uPSRuntime.pas (838)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetCurrency'
[dcc] ./uPSRuntime.pas (839)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetBool'
[dcc] ./uPSRuntime.pas (840)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.GetClass'
[dcc] ./uPSRuntime.pas (842)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetInt'
[dcc] ./uPSRuntime.pas (843)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetUInt'
[dcc] ./uPSRuntime.pas (845)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetInt64'
[dcc] ./uPSRuntime.pas (847)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetString'
[dcc] ./uPSRuntime.pas (848)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetAnsiString'
[dcc] ./uPSRuntime.pas (850)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetWideString'
[dcc] ./uPSRuntime.pas (851)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetUnicodeString'
[dcc] ./uPSRuntime.pas (853)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetReal'
[dcc] ./uPSRuntime.pas (854)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetCurrency'
[dcc] ./uPSRuntime.pas (855)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetBool'
[dcc] ./uPSRuntime.pas (856)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSStack.SetClass'
[dcc] ./uPSRuntime.pas (988)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'EPSException.Create'
[dcc] ./uPSRuntime.pas (1046)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'TPSRuntimeClassImporter.FindClass'
[dcc] ./uPSRuntime.pas (1100)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'IDispatchInvoke'
[dcc] ./uPSRuntime.pas (11632)
[dcc] Error: E2065 Unsatisfied forward or external declaration: 'MyAllMethodsHandler2'
[dcc] ./uPSRuntime.pas (531)
[dcc] Hint: H2219 Private symbol 'FValues' declared but never used
[dcc] ./uPSRuntime.pas (563)
[dcc] Hint: H2219 Private symbol 'FAttributes' declared but never used
[dcc] ./uPSComponent.pas (1374)
[dcc] Fatal: F2063 Could not compile used unit 'uPSRuntime.pas'

I am grateful for your assistance.

[Vizit0r]

MAC64 build available only for people with license exactly for 10.3.2. My license older, so i cant check it;.

[jdavison-mo]

Thanks. That makes sense why I see this. I'll dig a bit further and if I'm able to solve it post a pull request.

[Vizit0r]

The reason of all problems in OSX64 (and Linux64, i think also) with PS is
" The LongInt and LongWord Data Type are different on 64-bit POSIX platforms
To keep interoperability between Delphi and POSIX API, for 64-bit POSIX platforms, the size of LongInt and LongWord types are changed to 64-bit. All 32-bit platforms and 64-bit Windows platforms keep 32-bit for the LongInt and LongWord types." - http://docwiki.embarcadero.com/RADStudio/Rio/en/Delphi_Considerations_for_Multi-Device_Applications#The_LongInt_and_LongWord_Data_Type_are_different_on_64-bit_POSIX_platforms

So, fixing is versy simple - change ALL LongInt type to Integer. Files:
uPSCompiler, uPSComponent, uPSDebugger, uPSRuntime, uPSUtils

But dont change by autoreplace from "Longint" to "Integer", because in this case declarations like
AddTypeCopyN('Integer', 'LongInt');

and other - will be broken.

P.S. Ah, one more point to fix:
in uPSRuntime.pas
change lines

{$ifdef CPUX64}

{.$DEFINE empty_methods_handler}
{$ENDIF}

to

{$ifdef POSIX64}

{$DEFINE empty_methods_handler}
{$ENDIF}

looks like thats all.

Later on, when i will have time for check it on Linux64, i will arrange all this changes to commit. but i'm sure, that @carlokok will be unhappy for hundreds (or thousands?) of changed types everywhere.

P.P.S. As i see now, in FPC opposite situation - Integer has variable size, but LongInt is const.
Need to add another type, will do this later when will prepare commit.

[jdavison-mo]

I've just come back to check on this issue and see if anything has changed. I downloaded the latest code and got the same error.

Thanks @Vizit0r for your suggestions.

I wanted to explore what the issues were stopping it compiling. I found a number of conflict Integer implementation declarations mismatching their interface which was LongInt. I fixed those to LongInt. I realise this will increase the length for Linux64 but is this a problem? I only found a handful of these not too many.

I stubbed out 2 assembler routines which I hope could be translated to pure pascal by someone who understands their intent. I'm not sure what the assembler is doing

procedure MyAllMethodsHandler;
procedure PutOnFPUStackExtended(ft: extended);

Perhaps as suggested we can just {$DEFINE empty_methods_handler} to avoid the assembler. But I don't know what its trying to do, so is a stub acceptable or do we need it to do something? If a stub was acceptable, why didn't the implementer just do that on Windows in the first place instead of having complicated asm?

I've post my patches here:

master...jdavison-mo:issue-95-delphi-linux64-and-mac64

[jdavison-mo]

Progress has been made in that I've compiled the TestApplication sample with CrossVCL 1.27 for Mac64.

When I choose compile from the menu I receive the following error.

First chance exception at $0000000100419E9E. Exception class EAccessViolation with message 'Access violation at address 0000000100419E9E, accessing address 00000009017241F8'. Process TestApplication (5741)
Source Breakpoint at : C:\JD\pascalscript\Source\uPSRuntime.pas line 2060. Process TestApplication (5741)
First chance exception at $0000000100419E9E. Exception class EAccessViolation with message 'Access violation at address 0000000100419E9E, accessing address 00000009017241F8'. Process TestApplication (5741)
Source Breakpoint at : C:\JD\pascalscript\Source\uPSRuntime.pas line 2060. Process TestApplication (5741)

Upsruntime.TPSExec.Clear()(0x00000002017350d0)
Upsdebugger.TPSCustomDebugExec.Clear()(0x00000002017350d0)
Upscomponent.TPSScript.Compile()(0x0000000201734c20)
Fmain.TForm1.Compile1Click(System.TObject*)(0x00007ffeefbfe038)
Vcl.Menus.TMenuItem.Click()(0x0000000201734960)
Vcl.Menus.TMenu.DispatchCommand(unsigned short)(0x0000000201734340,2)
Vcl.Forms.TCustomForm.WMCommand(Winapi.Messages.TWMCommand&)(0x0000000205039ff0,0x00007ffeefbfe878)
:000000010001132B System::TObject::Dispatch(void*)
Vcl.Controls.TControl.WndProc(Winapi.Messages.TMessage&)(0x0000000205039ff0,0x00007ffeefbfe878)
Vcl.Controls.TWinControl.WndProc(Winapi.Messages.TMessage&)(0x0000000205039ff0,0x00007ffeefbfe878)
Vcl.Forms.TCustomForm.WndProc(Winapi.Messages.TMessage&)(0x0000000205039ff0,0x00007ffeefbfe878)
Vcl.Controls.TWinControl.MainWndProc(Winapi.Messages.TMessage&)(0x0000000205039ff0,0x00007ffeefbfe878)
:00000001013E5777 ___lldb_unnamed_function2542$$libcrossvcl64.dylib
:0000000101400450 ___lldb_unnamed_function3782$$libcrossvcl64.dylib
:000000010140E07B ___lldb_unnamed_function4430$$libcrossvcl64.dylib
:000000010140DF76 ___lldb_unnamed_function4428$$libcrossvcl64.dylib
:0000000101465FA3 ___lldb_unnamed_function6181$$libcrossvcl64.dylib
:00007FFF3EA22644 -[NSApplication(NSResponder) sendAction:to:from:]
:00007FFF3EA7E86B -[NSMenuItem _corePerformAction]
:00007FFF3EA7E5DC -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:]
:00007FFF3EAE258F -[NSMenu performActionForItemAtIndex:]
:00007FFF3EAE24FC -[NSMenu _internalPerformActionForItemAtIndex:]
:00007FFF3EAE232E -[NSCarbonMenuImpl _carbonCommandProcessEvent:handlerCallRef:]
:00007FFF3EA4CDC6 NSSLMMenuEventHandler
:00007FFF4039722E DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*)
:00007FFF403965DF SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*)
:00007FFF403B39B6 SendEventToEventTarget
:00007FFF40405CD2 SendHICommandEvent(unsigned int, HICommand const*, unsigned int, unsigned int, unsigned char, void const*, OpaqueEventTargetRef*, OpaqueEventTargetRef*, OpaqueEventRef**)
:00007FFF4042E14E SendMenuCommandWithContextAndModifiers
:00007FFF4042E0FD SendMenuItemSelectedEvent
:00007FFF4042DFE5 FinishMenuSelection(SelectionData*, MenuResult*, MenuResult*)
:00007FFF4042E9B3 MenuSelectCore(MenuData*, Point, double, unsigned int, OpaqueMenuRef**, unsigned short*)
:00007FFF4042E6C8 _HandleMenuSelection2
:00007FFF3E73AA81 _NSHandleCarbonMenuEvent
:00007FFF3E73A8E6 _DPSEventHandledByCarbon
:00007FFF3E72F92B -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:]
:0000000101418883 ___lldb_unnamed_function4761$$libcrossvcl64.dylib
:00000001013FD9C9 ___lldb_unnamed_function3667$$libcrossvcl64.dylib
:00000001001444B9 Winapi::Windows::WaitMessage()
Vcl.Forms.TApplication.Idle(tagMSG const&)(0x0000000204321960)
Vcl.Forms.TApplication.HandleMessage()(0x0000000204321960)
Vcl.Forms.TApplication.Run()(0x0000000204321960)
main(1,0x00007ffeefbff9a0,0x00007ffeefbff9b0,0x00007ffeefbffa68)
:00007FFF6D0C43D5 start

[jdavison-mo]

My code has been pushed so should be reproducable with by checking out my branch.

master...jdavison-mo:issue-95-delphi-linux64-and-mac64