From ea7a30d7c6ed957a592a1acb7582b39764029f17 Mon Sep 17 00:00:00 2001 From: Sofiia Kulish Date: Mon, 27 Jan 2025 16:58:41 +0100 Subject: [PATCH] PHP8.4 support --- src/PhpParser/NodeTransformer.php | 2 +- .../rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PhpParser/NodeTransformer.php b/src/PhpParser/NodeTransformer.php index 4541c6593d11..f9d42e25c3c9 100644 --- a/src/PhpParser/NodeTransformer.php +++ b/src/PhpParser/NodeTransformer.php @@ -113,7 +113,7 @@ private function splitMessageAndArgs(FuncCall $sprintfFuncCall) : ?SprintfString */ private function splitBySpace(string $value) : array { - $value = \str_getcsv($value, ' '); + $value = \str_getcsv($value, ' ', escape: '\\'); return \array_filter($value); } /** diff --git a/vendor/rector/rector-downgrade-php/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php b/vendor/rector/rector-downgrade-php/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php index 7a47caea4d21..9e951bffce57 100644 --- a/vendor/rector/rector-downgrade-php/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php +++ b/vendor/rector/rector-downgrade-php/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php @@ -19,7 +19,7 @@ public function __construct(NodeNameResolver $nodeNameResolver) { $this->nodeNameResolver = $nodeNameResolver; } - public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, Expr $expr = null) : void + public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, ?Expr $expr = null) : void { if ($bitwiseOr->left instanceof BitwiseOr) { /** @var BitwiseOr $leftLeft */