From 110b0ea8a7acd4abe27ec321552ac9dfe9f30d18 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sun, 30 Nov 2025 01:02:30 +0700 Subject: [PATCH 1/2] [CodeQuality] Skip with HTML on ShortenElseIfRector --- .../Fixture/skip_with_html.php.inc | 35 +++++++++++++++++++ .../Rector/If_/ShortenElseIfRector.php | 3 +- 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 rules-tests/CodeQuality/Rector/If_/ShortenElseIfRector/Fixture/skip_with_html.php.inc diff --git a/rules-tests/CodeQuality/Rector/If_/ShortenElseIfRector/Fixture/skip_with_html.php.inc b/rules-tests/CodeQuality/Rector/If_/ShortenElseIfRector/Fixture/skip_with_html.php.inc new file mode 100644 index 00000000000..27b76053e92 --- /dev/null +++ b/rules-tests/CodeQuality/Rector/If_/ShortenElseIfRector/Fixture/skip_with_html.php.inc @@ -0,0 +1,35 @@ + +
+ is_main_item) : ?> + +
+ icon ? $this->Icon->render($menuItem->icon) : '' ?> + +
+
+ is_external_url) { + echo $this->Html->link($title, $menuItem->url, [ + 'menu-icon' => $menuItem->icon ?? false, + 'class' => $aClass, + ]); + } elseif ($menuItem->parsed_url && $menuItem->is_url_valid) { + echo $this->Html->linkFromPath($title, $menuItem->parsed_url, [], [ + 'menu-icon' => $menuItem->icon ?? false, + 'class' => $aClass, + ]); + } else { + // Do something? + } + endif; ?> +
+ Date: Sat, 29 Nov 2025 18:21:51 +0000 Subject: [PATCH 2/2] [ci-review] Rector Rectify --- rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php | 1 + 1 file changed, 1 insertion(+) diff --git a/rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php b/rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php index 0a459c628ff..ceefebd412d 100644 --- a/rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php +++ b/rules/CodeQuality/Rector/FuncCall/SortNamedParamRector.php @@ -75,6 +75,7 @@ public function refactor(Node $node): ?Node if ($node instanceof CallLike && $node->isFirstClassCallable()) { return null; } + $args = $node instanceof Attribute ? $node->args : $node->getArgs(); if (count($args) <= 1) {