From 59a2c50f33c5c8592ea8122bb71d9b8a607444a6 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 7 Oct 2025 03:27:02 +0700 Subject: [PATCH 1/2] Fix php 7.4 regression on strtolower to false on ClassLikeNameClassNameImportSkipVoter --- build/target-repository/e2e/parse-php7-code/rector.php | 1 + .../ClassLikeNameClassNameImportSkipVoter.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/build/target-repository/e2e/parse-php7-code/rector.php b/build/target-repository/e2e/parse-php7-code/rector.php index 11af563f5c7..17e87172a11 100644 --- a/build/target-repository/e2e/parse-php7-code/rector.php +++ b/build/target-repository/e2e/parse-php7-code/rector.php @@ -9,4 +9,5 @@ $rectorConfig->paths([__DIR__.'/src']); $rectorConfig->sets([SetList::PHP_53]); + $rectorConfig->importNames(); }; diff --git a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php index fb522f0ecbd..035fda21883 100644 --- a/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php +++ b/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php @@ -47,7 +47,7 @@ public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedO $shortNameLowered = $fullyQualifiedObjectType->getShortNameLowered(); $fullyQualifiedObjectTypeNamespace = strtolower( - substr($fullyQualifiedObjectType->getClassName(), 0, -strlen($fullyQualifiedObjectType->getShortName()) - 1) + substr($fullyQualifiedObjectType->getClassName(), 0, -strlen($fullyQualifiedObjectType->getShortName()) - 1) ?: '' ); foreach ($classLikeNames as $classLikeName) { From 64d6b5755dd99cf498c8b7f401528f7a3e4f1b4d Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 7 Oct 2025 03:27:39 +0700 Subject: [PATCH 2/2] Fix php 7.4 regression on strtolower to false on ClassLikeNameClassNameImportSkipVoter --- build/target-repository/e2e/parse-php7-code/rector.php | 1 - 1 file changed, 1 deletion(-) diff --git a/build/target-repository/e2e/parse-php7-code/rector.php b/build/target-repository/e2e/parse-php7-code/rector.php index 17e87172a11..11af563f5c7 100644 --- a/build/target-repository/e2e/parse-php7-code/rector.php +++ b/build/target-repository/e2e/parse-php7-code/rector.php @@ -9,5 +9,4 @@ $rectorConfig->paths([__DIR__.'/src']); $rectorConfig->sets([SetList::PHP_53]); - $rectorConfig->importNames(); };