From 32438d7326d422f0e60b64cf21e0d76569ee808b Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 4 Oct 2025 04:29:45 +0700 Subject: [PATCH 1/2] Fix phpstan notice on RepeatedOrEqualToInArrayRector --- phpstan.neon | 7 +------ .../Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php | 4 +++- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/phpstan.neon b/phpstan.neon index 9f4e8e2777d..4e46cb48ee3 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -344,9 +344,4 @@ parameters: - identifier: symplify.noReference - message: '#Use explicit return value over magic &reference#' - - # known type - - - identifier: argument.type - message: '#Parameter \#1 \$expr of method Rector\\CodeQuality\\Rector\\BooleanOr\\RepeatedOrEqualToInArrayRector\:\:matchComparedExprAndValueExpr\(\) expects PhpParser\\Node\\Expr\\BinaryOp\\Equal\|PhpParser\\Node\\Expr\\BinaryOp\\Identical, PhpParser\\Node\\Expr given#' + message: '#Use explicit return value over magic &reference#' \ No newline at end of file diff --git a/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php b/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php index 84d04e4ce9c..ab12f207c6b 100644 --- a/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php +++ b/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php @@ -166,7 +166,9 @@ private function matchComparedAndDesiredValues(BooleanOr $booleanOr): ?array return null; } - $comparedExprAndValueExprs[] = $this->matchComparedExprAndValueExpr($currentBooleanOr->left->right); + /** @var Identical|Equal $leftRight */ + $leftRight = $currentBooleanOr->left->right; + $comparedExprAndValueExprs[] = $this->matchComparedExprAndValueExpr($leftRight); $currentBooleanOr = $currentBooleanOr->left; } From aca4320cf932c706927f137b1c5c55ca7b0eed02 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 4 Oct 2025 04:30:07 +0700 Subject: [PATCH 2/2] Fix phpstan notice on RepeatedOrEqualToInArrayRector --- phpstan.neon | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpstan.neon b/phpstan.neon index 4e46cb48ee3..756eba937d9 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -344,4 +344,4 @@ parameters: - identifier: symplify.noReference - message: '#Use explicit return value over magic &reference#' \ No newline at end of file + message: '#Use explicit return value over magic &reference#'