From dd24d8f764e47c69daf3e4020f314914cf34b18c Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 3 Oct 2025 06:15:45 +0700 Subject: [PATCH] [CodeQuality] Avoid too early findInstanceOf() usage on RepeatedOrEqualToInArrayRector --- .../Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php b/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php index 4d822bad2fd..4d0361a4476 100644 --- a/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php +++ b/rules/CodeQuality/Rector/BooleanOr/RepeatedOrEqualToInArrayRector.php @@ -65,9 +65,6 @@ public function getNodeTypes(): array */ public function refactor(Node $node): ?FuncCall { - $identicals = $this->betterNodeFinder->findInstanceOf($node, Identical::class); - $equals = $this->betterNodeFinder->findInstanceOf($node, Equal::class); - if (! $this->isEqualOrIdentical($node->right)) { return null; } @@ -106,6 +103,9 @@ public function refactor(Node $node): ?FuncCall $args = $this->nodeFactory->createArgs([$firstComparedExprAndValue->getComparedExpr(), $array]); + $identicals = $this->betterNodeFinder->findInstanceOf($node, Identical::class); + $equals = $this->betterNodeFinder->findInstanceOf($node, Equal::class); + if ($identicals !== [] && $equals === []) { $args[] = new Arg(new ConstFetch(new Name('true'))); }