From 1f2e2b1f64b60b5f5576b3057fbb6c1e161e540f Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sun, 14 Sep 2025 22:18:08 +0700 Subject: [PATCH 1/2] [CodingStyle] Early first class callable check on FunctionLikeToFirstClassCallableRector --- .../Fixture/skip_already_first_class_callable.php.inc | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 rules-tests/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector/Fixture/skip_already_first_class_callable.php.inc diff --git a/rules-tests/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector/Fixture/skip_already_first_class_callable.php.inc b/rules-tests/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector/Fixture/skip_already_first_class_callable.php.inc new file mode 100644 index 00000000000..565aa4860ca --- /dev/null +++ b/rules-tests/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector/Fixture/skip_already_first_class_callable.php.inc @@ -0,0 +1,5 @@ + Date: Sun, 14 Sep 2025 22:20:33 +0700 Subject: [PATCH 2/2] fix --- .../FunctionLike/FunctionLikeToFirstClassCallableRector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php b/rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php index 1ae74ca35e5..f08c840a2c0 100644 --- a/rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php +++ b/rules/CodingStyle/Rector/FunctionLike/FunctionLikeToFirstClassCallableRector.php @@ -76,11 +76,11 @@ private function shouldSkip( Scope $scope ): bool { $params = $node->getParams(); - $args = $callLike->getArgs(); if ($callLike->isFirstClassCallable()) { return true; } + $args = $callLike->getArgs(); if ($this->isChainedCall($callLike)) { return true; }