Add additional function_exists condition

Author: mttsch

rules-tests/Transform/Rector/FuncCall/WrapFuncCallWithPhpVersionIdCheckerRector/Fixture/skip_already_if_version_check_with_function_exists.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\Transform\Rector\FuncCall\WrapFuncCallWithPhpVersionIdCheckerRector\Fixture;
+
+if (function_exists('no_op_function') && PHP_VERSION_ID < 80500) {
+    no_op_function();
+}
+if (PHP_VERSION_ID < 80500 && function_exists('no_op_function')) {
+    no_op_function(1, 2);
+}
+
+?>

rules-tests/Transform/Rector/FuncCall/WrapFuncCallWithPhpVersionIdCheckerRector/Fixture/wrapped_function.php.inc

@@ -11,10 +11,10 @@ no_op_function(1, 2);
 
 namespace Rector\Tests\Transform\Rector\FuncCall\WrapFuncCallWithPhpVersionIdCheckerRector\Fixture;
 
-if (PHP_VERSION_ID < 80500) {
+if (function_exists('no_op_function') && PHP_VERSION_ID < 80500) {
     no_op_function();
 }
-if (PHP_VERSION_ID < 80500) {
+if (function_exists('no_op_function') && PHP_VERSION_ID < 80500) {
     no_op_function(1, 2);
 }
 

rules/Transform/Rector/FuncCall/WrapFuncCallWithPhpVersionIdCheckerRector.php

@@ -5,11 +5,16 @@
 namespace Rector\Transform\Rector\FuncCall;
 
 use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
 use PhpParser\Node\Expr\BinaryOp\Smaller;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PhpParser\Node\Scalar\Int_;
+use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\If_;
 use PhpParser\NodeVisitor;
@@ -89,9 +94,12 @@ public function refactor(Node $node): null|Node|int
                 }
 
                 $phpVersionIdConst = new ConstFetch(new Name('PHP_VERSION_ID'));
-                $if = new If_(new Smaller($phpVersionIdConst, new Int_(
-                    $wrapFuncCallWithPhpVersionIdChecker->getPhpVersionId()
-                )));
+                $if = new If_(new BooleanAnd(
+                    new FuncCall(new Name('function_exists'), [new Arg(new String_(
+                        $wrapFuncCallWithPhpVersionIdChecker->getFunctionName()
+                    ))]),
+                    new Smaller($phpVersionIdConst, new Int_($wrapFuncCallWithPhpVersionIdChecker->getPhpVersionId())),
+                ));
                 $if->stmts = [$stmt];
 
                 $node->stmts[$key] = $if;
@@ -120,17 +128,7 @@ private function isWrappedFuncCall(StmtsAwareInterface $node): bool
             return false;
         }
 
-        if (! $node->cond instanceof Smaller) {
-            return false;
-        }
-
-        if (! $node->cond->left instanceof ConstFetch || ! $this->isName($node->cond->left->name, 'PHP_VERSION_ID')) {
-            return false;
-        }
-
-        if (! $node->cond->right instanceof Int_) {
-            return false;
-        }
+        $phpVersionIdComparison = $this->getPhpVersionIdComparison($node->cond);
 
         if (count($node->stmts) !== 1) {
             return false;
@@ -145,7 +143,7 @@ private function isWrappedFuncCall(StmtsAwareInterface $node): bool
         foreach ($this->wrapFuncCallWithPhpVersionIdCheckers as $wrapFuncCallWithPhpVersionIdChecker) {
             if (
                 $this->getName($childStmt->expr) !== $wrapFuncCallWithPhpVersionIdChecker->getFunctionName()
-                || $node->cond->right->value !== $wrapFuncCallWithPhpVersionIdChecker->getPhpVersionId()
+                || $phpVersionIdComparison->right->value !== $wrapFuncCallWithPhpVersionIdChecker->getPhpVersionId()
             ) {
                 continue;
             }
@@ -155,4 +153,25 @@ private function isWrappedFuncCall(StmtsAwareInterface $node): bool
 
         return false;
     }
+
+    private function getPhpVersionIdComparison(Expr $expr): ?Smaller
+    {
+        if ($expr instanceof BooleanAnd) {
+            return $this->getPhpVersionIdComparison($expr->left) ?? $this->getPhpVersionIdComparison($expr->right);
+        }
+
+        if (! $expr instanceof Smaller) {
+            return null;
+        }
+
+        if (! $expr->left instanceof ConstFetch || ! $this->isName($expr->left->name, 'PHP_VERSION_ID')) {
+            return null;
+        }
+
+        if (! $expr->right instanceof Int_) {
+            return null;
+        }
+
+        return $expr;
+    }
 }