[CodeQuality] Skip dynamic key on InlineArrayReturnAssignRector (#7275)

* [CodeQuality] Skip dynamic key on InlineArrayReturnAssignRector

* Fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: samsonasik

rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_dynamic_key.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector\Fixture;
+
+final class SkipDynamicKey
+{
+    public function create($variable, $type, $data)
+    {
+        $someVar[sprintf('%', $type)] = 0.0;
+        $someVar[$type] = 0.0;
+
+        return $someVar;
+    }
+}

rules/CodeQuality/NodeAnalyzer/VariableDimFetchAssignResolver.php

@@ -11,11 +11,13 @@
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Return_;
 use Rector\CodeQuality\ValueObject\KeyAndExpr;
+use Rector\NodeAnalyzer\ExprAnalyzer;
 use Rector\PhpParser\Node\Value\ValueResolver;
 
 final readonly class VariableDimFetchAssignResolver
 {
     public function __construct(
+        private ExprAnalyzer $exprAnalyzer,
         private ValueResolver $valueResolver
     ) {
     }
@@ -54,6 +56,10 @@ public function resolveFromStmtsAndVariable(array $stmts, ?Assign $emptyArrayAss
 
             $arrayDimFetch = $assign->var;
             while ($arrayDimFetch instanceof ArrayDimFetch) {
+                if ($arrayDimFetch->dim instanceof Expr && $this->exprAnalyzer->isDynamicExpr($arrayDimFetch->dim)) {
+                    return [];
+                }
+
                 $dimValues[] = $arrayDimFetch->dim instanceof Expr ? $this->valueResolver->getValue(
                     $arrayDimFetch->dim
                 ) : $key;

rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php

@@ -107,7 +107,7 @@ public function refactor(Node $node): ?Node
         }
 
         // init maybe from before if
-        if ($emptyArrayAssign === null && ! $node instanceof FunctionLike) {
+        if (!$emptyArrayAssign instanceof Assign && ! $node instanceof FunctionLike) {
             return null;
         }