[ci] add short class fixture names check to avoid node class names

TomasVotruba · TomasVotruba · commit b4f559bd13aa · 2025-10-23T15:28:32.000+02:00
diff --git a/.github/workflows/code_analysis.yaml b/.github/workflows/code_analysis.yaml
@@ -56,6 +56,10 @@ jobs:
                         name: 'Check before/after test fixture on no-changes'
                         run: php scripts/check-before-after-same-fixtures.php
 
+                    -
+                        name: 'Check fixture classes are different to nodes'
+                        run: php scripts/avoid-short-node-names-in-fixtures.php
+
                     -
                         name: 'Check no "*.php" files in rules Fixture directory'
                         run: php scripts/no-php-file-in-fixtures.php
diff --git a/composer-dependency-analyser.php b/composer-dependency-analyser.php
@@ -17,9 +17,6 @@
     // ensure use version ^3.2.0
     ->ignoreErrorsOnPackage('composer/pcre', [ErrorType::UNUSED_DEPENDENCY])
 
-    // use din /bin, but only local script
-    ->ignoreErrorsOnPackage('nette/robot-loader', [ErrorType::DEV_DEPENDENCY_IN_PROD])
-
     ->ignoreErrorsOnPaths([
         __DIR__ . '/stubs',
         __DIR__ . '/tests',
diff --git a/rules-tests/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector/Fixture/flip_instance_nullable_type.php.inc b/rules-tests/CodeQuality/Rector/Identical/FlipTypeControlToUseExclusiveTypeRector/Fixture/flip_instance_nullable_type.php.inc
@@ -4,7 +4,7 @@ namespace Rector\Tests\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiv
 
 use stdClass;
 
-class NullableType
+final class FlipInstanceNullableType
 {
     public function run()
     {
@@ -32,7 +32,7 @@ namespace Rector\Tests\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiv
 
 use stdClass;
 
-class NullableType
+final class FlipInstanceNullableType
 {
     public function run()
     {
diff --git a/rules-tests/DeadCode/Rector/For_/RemoveDeadContinueRector/Fixture/continue_inside_do.php.inc b/rules-tests/DeadCode/Rector/For_/RemoveDeadContinueRector/Fixture/continue_inside_do.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;
 
-class Do_
+final class ContinueInsideDo
 {
     public function run()
     {
@@ -19,7 +19,7 @@ class Do_
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;
 
-class Do_
+final class ContinueInsideDo
 {
     public function run()
     {
diff --git a/rules-tests/DeadCode/Rector/For_/RemoveDeadContinueRector/Fixture/continue_inside_foreach.php.inc b/rules-tests/DeadCode/Rector/For_/RemoveDeadContinueRector/Fixture/continue_inside_foreach.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;
 
-class Foreach_
+final class ContinueInsideForeach
 {
     public function run($values)
     {
@@ -19,7 +19,7 @@ class Foreach_
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;
 
-class Foreach_
+final class ContinueInsideForeach
 {
     public function run($values)
     {
diff --git a/rules-tests/DeadCode/Rector/For_/RemoveDeadContinueRector/Fixture/inside_while.php.inc b/rules-tests/DeadCode/Rector/For_/RemoveDeadContinueRector/Fixture/inside_while.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;
 
-class While_
+final class InsideWhile
 {
     public function run()
     {
@@ -19,7 +19,7 @@ class While_
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;
 
-class While_
+final class InsideWhile
 {
     public function run()
     {
diff --git a/rules-tests/DeadCode/Rector/For_/RemoveDeadLoopRector/Fixture/empty_do.php.inc b/rules-tests/DeadCode/Rector/For_/RemoveDeadLoopRector/Fixture/empty_do.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadLoopRector\Fixture;
 
-class Do_
+final class EmptyDo
 {
     public function run()
     {
@@ -18,7 +18,7 @@ class Do_
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadLoopRector\Fixture;
 
-class Do_
+final class EmptyDo
 {
     public function run()
     {
diff --git a/rules-tests/DeadCode/Rector/For_/RemoveDeadLoopRector/Fixture/empty_foreach.php.inc b/rules-tests/DeadCode/Rector/For_/RemoveDeadLoopRector/Fixture/empty_foreach.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadLoopRector\Fixture;
 
-class Foreach_
+final class EmptyForeach
 {
     public function run($values)
     {
@@ -17,7 +17,7 @@ class Foreach_
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadLoopRector\Fixture;
 
-class Foreach_
+final class EmptyForeach
 {
     public function run($values)
     {
diff --git a/rules-tests/DeadCode/Rector/For_/RemoveDeadLoopRector/Fixture/empty_while.php.inc b/rules-tests/DeadCode/Rector/For_/RemoveDeadLoopRector/Fixture/empty_while.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadLoopRector\Fixture;
 
-class While_
+final class EmptyWhile
 {
     public function run()
     {
@@ -17,7 +17,7 @@ class While_
 
 namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadLoopRector\Fixture;
 
-class While_
+final class EmptyWhile
 {
     public function run()
     {
diff --git a/rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/split_or_identical.php.inc b/rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/split_or_identical.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector\Fixture;
 
-class Identical
+final class SplitOrIdentical
 {
     public function canDrive(Car $newCar)
     {
@@ -22,7 +22,7 @@ class Identical
 
 namespace Rector\Tests\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector\Fixture;
 
-class Identical
+final class SplitOrIdentical
 {
     public function canDrive(Car $newCar)
     {
diff --git a/rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/exit.php.inc b/rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/exit.php.inc
diff --git a/rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/if_return.php.inc b/rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/if_return.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\EarlyReturn\Rector\If_\RemoveAlwaysElseRector\Fixture;
 
-class ElseIf_
+final class IfReturn
 {
     public function run()
     {
@@ -24,7 +24,7 @@ class ElseIf_
 
 namespace Rector\Tests\EarlyReturn\Rector\If_\RemoveAlwaysElseRector\Fixture;
 
-class ElseIf_
+final class IfReturn
 {
     public function run()
     {
diff --git a/rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/split_after_throw.php.inc b/rules-tests/EarlyReturn/Rector/If_/RemoveAlwaysElseRector/Fixture/split_after_throw.php.inc
@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\EarlyReturn\Rector\If_\RemoveAlwaysElseRector\Fixture;
 
-class Throw_
+final class SplitAfterThrow
 {
     public function run()
     {
@@ -21,7 +21,7 @@ class Throw_
 
 namespace Rector\Tests\EarlyReturn\Rector\If_\RemoveAlwaysElseRector\Fixture;
 
-class Throw_
+final class SplitAfterThrow
 {
     public function run()
     {
diff --git a/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/aliased_with_multi_properties.php.inc b/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/aliased_with_multi_properties.php.inc
@@ -7,7 +7,7 @@ namespace OpenApi\Attributes
     use OpenApi\Annotations as OA;
 
     #[\Attribute]
-    class Property {}
+    class FirstProperty {}
 
     class TestClass
     {
@@ -35,7 +35,7 @@ namespace OpenApi\Attributes
     use OpenApi\Attributes as OA;
 
     #[\Attribute]
-    class Property {}
+    class FirstProperty {}
 
     class TestClass
     {
@@ -48,4 +48,4 @@ namespace OpenApi\Attributes
 
 }
 
-?>
+?>
diff --git a/rules-tests/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/Fixture/nullable_type.php.inc b/rules-tests/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/Fixture/nullable_type.php.inc
@@ -4,7 +4,7 @@ namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromo
 
 use DateTimeInterface;
 
-class NullableType
+final class MergeWithNullableType
 {
     private ?DateTimeInterface $time;
 
@@ -22,7 +22,7 @@ namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromo
 
 use DateTimeInterface;
 
-class NullableType
+final class MergeWithNullableType
 {
     public function __construct(private ?DateTimeInterface $time = null)
     {
diff --git a/scripts/avoid-short-node-names-in-fixtures.php b/scripts/avoid-short-node-names-in-fixtures.php
@@ -4,11 +4,63 @@
 
 declare(strict_types=1);
 
+use Nette\Utils\Strings;
+use Rector\Scripts\Finder\FixtureFinder;
+use Symfony\Component\Console\Input\ArrayInput;
+use Symfony\Component\Console\Output\ConsoleOutput;
+use Symfony\Component\Console\Style\SymfonyStyle;
+
 require __DIR__ . '/../vendor/autoload.php';
 
-$fixtureFiles = \Rector\Scripts\Finder\FixtureFinder::find([__DIR__ . '/../tests', __DIR__ . '/../rules-tests']);
+$fixtureFiles = FixtureFinder::find([__DIR__ . '/../tests', __DIR__ . '/../rules-tests']);
+
+// get short node names
+
+$nodeFileFinder = \Symfony\Component\Finder\Finder::create()
+    ->files()
+    ->name('*.php')
+    ->in(__DIR__ . '/../vendor/nikic/php-parser/lib/PhpParser/Node');
+
+/** @var \Symfony\Component\Finder\SplFileInfo[] $nodeFileInfos */
+$nodeFileInfos = iterator_to_array($nodeFileFinder->getIterator());
+
+$shortNodeClassNames = [];
+foreach ($nodeFileInfos as $nodeFileInfo) {
+    $shortNodeClassNames[] = $nodeFileInfo->getBasename('.php');
+}
+
+$symfonyStyle = new SymfonyStyle(new ArrayInput([]), new ConsoleOutput());
+
+$hasErrors = false;
 
 foreach ($fixtureFiles as $fixtureFileInfo) {
-    $shortClassNameMatch = \Nette\Utils\Strings::match($fixtureFileInfo->getContents(), '/\b(?:class|interface)\s+([A-Z][A-Za-z0-9_]*)/');
-    dump($shortClassNameMatch);
+    $shortClassNameMatch = Strings::match(
+        $fixtureFileInfo->getContents(),
+        '/\b(?:class|interface)\s+(?<name>[A-Z][A-Za-z0-9_]*)/'
+    );
+    if ($shortClassNameMatch === null) {
+        continue;
+    }
+
+    $fixtureClassName = $shortClassNameMatch['name'];
+    if (! in_array($fixtureClassName, $shortNodeClassNames, true)) {
+        continue;
+    }
+
+    $symfonyStyle->writeln(sprintf(
+        'Fixture class name "%s" conflicts with native short node name.%sChange it to different to avoid IDE incorrect autocomplete:%s%s%s',
+        $fixtureClassName,
+        PHP_EOL,
+        PHP_EOL,
+        $fixtureFileInfo->getRealPath(),
+        PHP_EOL
+    ));
+
+    $hasErrors = true;
 }
+
+if ($hasErrors) {
+    exit(1);
+}
+
+exit(0);
diff --git a/scripts/list-unused-rules.php b/scripts/list-unused-rules.php
@@ -2,16 +2,12 @@
 
 declare(strict_types=1);
 
-use Nette\Loaders\RobotLoader;
 use Rector\Bridge\SetRectorsResolver;
 use Rector\Scripts\Finder\RectorClassFinder;
 use Rector\Scripts\Finder\RectorSetFilesFinder;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\ConsoleOutput;
 use Symfony\Component\Console\Style\SymfonyStyle;
-use Symfony\Component\Finder\Finder;
-use Symfony\Component\Finder\SplFileInfo;
-use Webmozart\Assert\Assert;
 
 require __DIR__ . '/../vendor/autoload.php';
 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ namespace Rector\Tests\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiv`
`4`	`4`
`5`	`5`	`use stdClass;`
`6`	`6`
`7`		`-class NullableType`
	`7`	`+final class FlipInstanceNullableType`
`8`	`8`	`{`
`9`	`9`	`public function run()`
`10`	`10`	`{`
`@@ -32,7 +32,7 @@ namespace Rector\Tests\CodeQuality\Rector\Identical\FlipTypeControlToUseExclusiv`
`32`	`32`
`33`	`33`	`use stdClass;`
`34`	`34`
`35`		`-class NullableType`
	`35`	`+final class FlipInstanceNullableType`
`36`	`36`	`{`
`37`	`37`	`public function run()`
`38`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;`
`4`	`4`
`5`		`-class Do_`
	`5`	`+final class ContinueInsideDo`
`6`	`6`	`{`
`7`	`7`	`public function run()`
`8`	`8`	`{`
`@@ -19,7 +19,7 @@ class Do_`
`19`	`19`
`20`	`20`	`namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;`
`21`	`21`
`22`		`-class Do_`
	`22`	`+final class ContinueInsideDo`
`23`	`23`	`{`
`24`	`24`	`public function run()`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;`
`4`	`4`
`5`		`-class Foreach_`
	`5`	`+final class ContinueInsideForeach`
`6`	`6`	`{`
`7`	`7`	`public function run($values)`
`8`	`8`	`{`
`@@ -19,7 +19,7 @@ class Foreach_`
`19`	`19`
`20`	`20`	`namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;`
`21`	`21`
`22`		`-class Foreach_`
	`22`	`+final class ContinueInsideForeach`
`23`	`23`	`{`
`24`	`24`	`public function run($values)`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;`
`4`	`4`
`5`		`-class While_`
	`5`	`+final class InsideWhile`
`6`	`6`	`{`
`7`	`7`	`public function run()`
`8`	`8`	`{`
`@@ -19,7 +19,7 @@ class While_`
`19`	`19`
`20`	`20`	`namespace Rector\Tests\DeadCode\Rector\For_\RemoveDeadContinueRector\Fixture;`
`21`	`21`
`22`		`-class While_`
	`22`	`+final class InsideWhile`
`23`	`23`	`{`
`24`	`24`	`public function run()`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Rector\Tests\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector\Fixture;`
`4`	`4`
`5`		`-class Identical`
	`5`	`+final class SplitOrIdentical`
`6`	`6`	`{`
`7`	`7`	`public function canDrive(Car $newCar)`
`8`	`8`	`{`
`@@ -22,7 +22,7 @@ class Identical`
`22`	`22`
`23`	`23`	`namespace Rector\Tests\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector\Fixture;`
`24`	`24`
`25`		`-class Identical`
	`25`	`+final class SplitOrIdentical`
`26`	`26`	`{`
`27`	`27`	`public function canDrive(Car $newCar)`
`28`	`28`	`{`