Skip to content

Commit b4e964f

Browse files
authored
[Php81] Keep nullable param on NewInInitializerRector (#7545)
1 parent 0e18562 commit b4e964f

File tree

11 files changed

+11
-15
lines changed

11 files changed

+11
-15
lines changed

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_class_const_fetch_arg.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Source\SomeValu
2727

2828
class PassClassConstFetchArg
2929
{
30-
public function __construct(private DateTime $dateTime = new DateTime(SomeValueObject::NOW))
30+
public function __construct(private ?DateTime $dateTime = new DateTime(SomeValueObject::NOW))
3131
{
3232
}
3333
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_const_fetch_arg.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const NOW = 'now';
2929

3030
class PassConstFetchArg
3131
{
32-
public function __construct(private DateTime $dateTime = new DateTime(NOW))
32+
public function __construct(private ?DateTime $dateTime = new DateTime(NOW))
3333
{
3434
}
3535
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use DateTimeZone;
2727

2828
class PassNonDynamicArg
2929
{
30-
public function __construct(private DateTime $dateTime = new DateTime('now', new DateTimeZone('Asia/Jakarta')))
30+
public function __construct(private ?DateTime $dateTime = new DateTime('now', new DateTimeZone('Asia/Jakarta')))
3131
{
3232
}
3333
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg2.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2121

2222
class SomeClass
2323
{
24-
public function __construct(private Logger $logger = new NullLogger(['a' => 'b']))
24+
public function __construct(private ?Logger $logger = new NullLogger(['a' => 'b']))
2525
{
2626
}
2727
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg3.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2121

2222
class SomeClass
2323
{
24-
public function __construct(private Logger $logger = new NullLogger(['b']))
24+
public function __construct(private ?Logger $logger = new NullLogger(['b']))
2525
{
2626
}
2727
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg4.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use stdClass;
2525

2626
class SomeClass
2727
{
28-
public function __construct(private Logger $logger = new NullLogger([new stdClass]))
28+
public function __construct(private ?Logger $logger = new NullLogger([new stdClass]))
2929
{
3030
}
3131
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg5.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2121

2222
class SomeClass
2323
{
24-
public function __construct(private Logger $logger = new NullLogger([]))
24+
public function __construct(private ?Logger $logger = new NullLogger([]))
2525
{
2626
}
2727
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg6.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2121

2222
class SomeClass
2323
{
24-
public function __construct(private Logger $logger = new NullLogger(new Db()))
24+
public function __construct(private ?Logger $logger = new NullLogger(new Db()))
2525
{
2626
}
2727
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/property_with_attributes.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class Carrier
3434
public function __construct(
3535
#[ORM\Id]
3636
#[ORM\Column(type: 'ulid', unique: true)]
37-
private Ulid $id = new Ulid()
37+
private ?Ulid $id = new Ulid()
3838
)
3939
{
4040
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/some_class.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2121

2222
class SomeClass
2323
{
24-
public function __construct(private Logger $logger = new NullLogger)
24+
public function __construct(private ?Logger $logger = new NullLogger)
2525
{
2626
}
2727
}

0 commit comments

Comments
 (0)