[CodingStyle] Skip non-native array type on PHP 7.4 for ArraySpreadInsteadOfArrayMergeRector (#7248)

* [CodingStyle] Skip non-native array type on PHP 7.4 for ArraySpreadInsteadOfArrayMergeRector

* [CodingStyle] Skip non-native array type on PHP 7.4 for ArraySpreadInsteadOfArrayMergeRector

* [CodingStyle] Skip non-native array type on PHP 7.4 for ArraySpreadInsteadOfArrayMergeRector

* [CodingStyle] Skip non-native array type on PHP 7.4 for ArraySpreadInsteadOfArrayMergeRector

Author: samsonasik

rules-tests/CodingStyle/Rector/FuncCall/ArraySpreadInsteadOfArrayMergeRector/FixturePhp74/skip_doblock_based_type_array_merge.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector\FixturePhp74;
+
+class SkipDocblockBasedTypeArrayMerge
+{
+    /**
+     * @param array<int, string> $iter1
+     * @param array<int, string> $iter2
+     */
+    public function run($iter1, $iter2)
+    {
+        $values = array_merge($iter1, $iter2);
+    }
+}

rules/CodingStyle/Rector/FuncCall/ArraySpreadInsteadOfArrayMergeRector.php

@@ -135,6 +135,14 @@ private function shouldSkipArrayForInvalidKeys(Expr $expr): bool
         $type = $this->getType($expr);
 
         if ($type->getIterableKeyType()->isInteger()->yes()) {
+            // when on PHP 8.0+, pass non-array values already error on the first place
+            // this check avoid unpack non-array values that cause error on php 7.4 as well,
+            // @see https://3v4l.org/DuYHu#v7.4.33
+            if (! $this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::ARRAY_ON_ARRAY_MERGE)) {
+                $nativeType = $this->nodeTypeResolver->getNativeType($expr);
+                return ! $nativeType->isArray()->yes();
+            }
+
             return false;
         }
 

src/ValueObject/PhpVersionFeature.php

@@ -653,6 +653,12 @@ final class PhpVersionFeature
      */
     public const MIXED_TYPE = PhpVersion::PHP_80;
 
+    /**
+     * @see https://3v4l.org/OWtO5
+     * @var int
+     */
+    public const ARRAY_ON_ARRAY_MERGE = PhpVersion::PHP_80;
+
     /**
      * @var int
      */