Skip to content

Commit 0584920

Browse files
authored
[type-declaration-docblocks] Register DocblockReturnArrayFromDirectArrayInstanceRector to set (#7280)
1 parent afd68f2 commit 0584920

4 files changed

Lines changed: 21 additions & 10 deletions

File tree

config/set/type-declaration-docblocks.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,27 @@
1212
use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddParamArrayDocblockFromDimFetchAccessRector;
1313
use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForCommonObjectDenominatorRector;
1414
use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockGetterReturnArrayFromPropertyDocblockVarRector;
15+
use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector;
1516

1617
/**
1718
* @experimental * 2025-09, experimental hidden set for type declaration in docblocks
1819
*/
1920
return static function (RectorConfig $rectorConfig): void {
2021
$rectorConfig->rules([
21-
AddReturnArrayDocblockBasedOnArrayMapRector::class,
22-
AddReturnDocblockForScalarArrayFromAssignsRector::class,
22+
// property var
2323
DocblockVarFromParamDocblockInConstructorRector::class,
24-
DocblockGetterReturnArrayFromPropertyDocblockVarRector::class,
25-
AddReturnDocblockForCommonObjectDenominatorRector::class,
24+
25+
// param
2626
AddParamArrayDocblockFromDimFetchAccessRector::class,
2727
ClassMethodArrayDocblockParamFromLocalCallsRector::class,
28+
29+
// return
30+
DocblockGetterReturnArrayFromPropertyDocblockVarRector::class,
31+
AddReturnDocblockForCommonObjectDenominatorRector::class,
32+
AddReturnArrayDocblockBasedOnArrayMapRector::class,
33+
AddReturnDocblockForScalarArrayFromAssignsRector::class,
34+
DocblockReturnArrayFromDirectArrayInstanceRector::class,
35+
2836
// tests
2937
AddParamArrayDocblockFromDataProviderRector::class,
3038
AddReturnDocblockDataProviderRector::class,

rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public function refactor(Node $node): ?Node
107107
}
108108

109109
// init maybe from before if
110-
if (!$emptyArrayAssign instanceof Assign && ! $node instanceof FunctionLike) {
110+
if (! $emptyArrayAssign instanceof Assign && ! $node instanceof FunctionLike) {
111111
return null;
112112
}
113113

rules/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44

55
namespace Rector\CodingStyle\Rector\Enum_;
66

7-
use PHPStan\BetterReflection\Reflector\DefaultReflector;
8-
use PHPStan\BetterReflection\Reflector\Exception\IdentifierNotFound;
9-
use PHPStan\Reflection\ClassReflection;
107
use PhpParser\Node;
118
use PhpParser\Node\Expr\ClassConstFetch;
129
use PhpParser\Node\Identifier;
1310
use PhpParser\Node\Name;
1411
use PhpParser\Node\Stmt\Enum_;
1512
use PhpParser\Node\Stmt\EnumCase;
13+
use PHPStan\BetterReflection\Reflector\DefaultReflector;
14+
use PHPStan\BetterReflection\Reflector\Exception\IdentifierNotFound;
15+
use PHPStan\Reflection\ClassReflection;
1616
use Rector\Configuration\Option;
1717
use Rector\Configuration\Parameter\SimpleParameterProvider;
1818
use Rector\NodeTypeResolver\Reflection\BetterReflection\SourceLocatorProvider\DynamicSourceLocatorProvider;
@@ -192,7 +192,10 @@ private function isUsedOutsideOfProject(Name $name): bool
192192
private function isEnumCase(ClassReflection $classReflection, string $name, string $pascalName): bool
193193
{
194194
// the enum case might have already been renamed, need to check both
195-
return $classReflection->hasEnumCase($name) || $classReflection->hasEnumCase($pascalName);
195+
if ($classReflection->hasEnumCase($name)) {
196+
return true;
197+
}
198+
return $classReflection->hasEnumCase($pascalName);
196199
}
197200

198201
private function convertToPascalCase(string $name): string

src/PhpParser/Node/NodeFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
namespace Rector\PhpParser\Node;
66

7-
use PhpParser\Node\Expr\New_;
87
use PhpParser\Builder\Method;
98
use PhpParser\Builder\Param as ParamBuilder;
109
use PhpParser\Builder\Property as PropertyBuilder;
@@ -27,6 +26,7 @@
2726
use PhpParser\Node\Expr\ConstFetch;
2827
use PhpParser\Node\Expr\FuncCall;
2928
use PhpParser\Node\Expr\MethodCall;
29+
use PhpParser\Node\Expr\New_;
3030
use PhpParser\Node\Expr\PropertyFetch;
3131
use PhpParser\Node\Expr\StaticCall;
3232
use PhpParser\Node\Expr\StaticPropertyFetch;

0 commit comments

Comments
 (0)