From 0119a3580188a38aedbef2f091b5fa13811a53a4 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 5 Sep 2025 07:36:22 +0700 Subject: [PATCH 1/2] [CodeQuality] Handle crash on no @depends on AddParamTypeFromDependsRector --- .../Fixture/skip_no_depends.php.inc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 rules-tests/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector/Fixture/skip_no_depends.php.inc diff --git a/rules-tests/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector/Fixture/skip_no_depends.php.inc b/rules-tests/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector/Fixture/skip_no_depends.php.inc new file mode 100644 index 00000000..e8e033b1 --- /dev/null +++ b/rules-tests/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector/Fixture/skip_no_depends.php.inc @@ -0,0 +1,17 @@ + Date: Fri, 5 Sep 2025 07:37:25 +0700 Subject: [PATCH 2/2] Fix --- .../Rector/Class_/AddParamTypeFromDependsRector.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rules/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector.php b/rules/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector.php index 2add1a73..8d9ae2ce 100644 --- a/rules/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector.php +++ b/rules/CodeQuality/Rector/Class_/AddParamTypeFromDependsRector.php @@ -135,6 +135,10 @@ private function resolveReturnTypeOfDependsMethod(ClassMethod $classMethod, Clas { $dependsMethodName = $this->resolveDependsAnnotationOrAttributeMethod($classMethod); + if ($dependsMethodName === null || $dependsMethodName === '') { + return null; + } + $dependsClassMethod = $class->getMethod($dependsMethodName); if (! $dependsClassMethod instanceof ClassMethod) {