From a699caf35db80d10a8c17f46a6024854c0c448c1 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 1 Sep 2025 22:14:04 +0700 Subject: [PATCH] Remove unused check return with expr as already covered on ReturnAnalyzer --- .../Class_/AddReturnTypeToDependedRector.php | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php b/rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php index f4894495..54ceded1 100644 --- a/rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php +++ b/rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php @@ -5,9 +5,7 @@ namespace Rector\PHPUnit\CodeQuality\Rector\Class_; use PhpParser\Node; -use PhpParser\Node\Expr; use PhpParser\Node\Stmt\Class_; -use PhpParser\Node\Stmt\ClassMethod; use Rector\PhpParser\Node\BetterNodeFinder; use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer; @@ -97,10 +95,6 @@ public function refactor(Node $node): ?Node continue; } - if (! $this->haveAllReturnsExpr($classMethod)) { - continue; - } - // already known return type if ($classMethod->returnType instanceof Node) { continue; @@ -135,16 +129,4 @@ public function refactor(Node $node): ?Node return $node; } - - private function haveAllReturnsExpr(ClassMethod $classMethod): bool - { - $returns = $this->betterNodeFinder->findReturnsScoped($classMethod); - foreach ($returns as $return) { - if (! $return->expr instanceof Expr) { - return false; - } - } - - return true; - } }