From 69d92f42f894b455970cfeae2dbef9c8cc59041f Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sun, 19 Jan 2025 16:49:59 +0000 Subject: [PATCH 1/3] add failing fixture --- .../Fixture/cover_static_call.php.inc | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 rules-tests/CodeQuality/Rector/MethodCall/FlipAssertRector/Fixture/cover_static_call.php.inc diff --git a/rules-tests/CodeQuality/Rector/MethodCall/FlipAssertRector/Fixture/cover_static_call.php.inc b/rules-tests/CodeQuality/Rector/MethodCall/FlipAssertRector/Fixture/cover_static_call.php.inc new file mode 100644 index 00000000..b8f391ae --- /dev/null +++ b/rules-tests/CodeQuality/Rector/MethodCall/FlipAssertRector/Fixture/cover_static_call.php.inc @@ -0,0 +1,33 @@ + +----- + From 6846ad9b4207e944c7827f996ddf98c9fec6d419 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sun, 19 Jan 2025 16:53:41 +0000 Subject: [PATCH 2/3] add contains string to flip assert --- rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php b/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php index 5402f9c4..f4c7d6b3 100644 --- a/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php +++ b/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php @@ -78,7 +78,7 @@ public function getNodeTypes(): array */ public function refactor(Node $node): ?Node { - if (! $this->testsNodeAnalyzer->isPHPUnitMethodCallNames($node, ['assertSame', 'assertEquals'])) { + if (! $this->testsNodeAnalyzer->isPHPUnitMethodCallNames($node, ['assertSame', 'assertEquals', 'assertStringContainsString'])) { return null; } From cc9c73b9d867f91644b675b23b7d0c1d385266d7 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Sun, 19 Jan 2025 16:55:04 +0000 Subject: [PATCH 3/3] [ci-review] Rector Rectify --- rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php b/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php index f4c7d6b3..bd1c2a1c 100644 --- a/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php +++ b/rules/CodeQuality/Rector/MethodCall/FlipAssertRector.php @@ -78,7 +78,10 @@ public function getNodeTypes(): array */ public function refactor(Node $node): ?Node { - if (! $this->testsNodeAnalyzer->isPHPUnitMethodCallNames($node, ['assertSame', 'assertEquals', 'assertStringContainsString'])) { + if (! $this->testsNodeAnalyzer->isPHPUnitMethodCallNames( + $node, + ['assertSame', 'assertEquals', 'assertStringContainsString'] + )) { return null; }