From 415268c4b3a80a6f858b95cf877fd087ab30e99c Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Tue, 10 Dec 2024 03:11:58 +0700
Subject: [PATCH 1/2] [Phpunit] Avoid reprint doc for remove/replace when no
 @return tag on YieldDataProviderRector

---
 rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php b/rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php
index 51710228..b5fc84ef 100644
--- a/rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php
+++ b/rules/CodeQuality/Rector/Class_/YieldDataProviderRector.php
@@ -173,6 +173,10 @@ private function removeReturnTag(ClassMethod $classMethod): void
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);
 
+        if (! $phpDocInfo->getReturnTagValue() instanceof ReturnTagValueNode) {
+            return;
+        }
+
         if ($phpDocInfo->getReturnType() instanceof ArrayType) {
             $keyType = $phpDocInfo->getReturnType()
                 ->getIterableKeyType();

From 783457ac240a4d92337762fa8f479d852d7a3bdb Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Tue, 10 Dec 2024 03:13:13 +0700
Subject: [PATCH 2/2] add fixture

---
 .../Fixture/with_comment.php.inc              | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/with_comment.php.inc

diff --git a/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/with_comment.php.inc b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/with_comment.php.inc
new file mode 100644
index 00000000..82ddd76c
--- /dev/null
+++ b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/with_comment.php.inc
@@ -0,0 +1,51 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\YieldDataProviderRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class WithComment extends TestCase
+{
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')]
+    public function test(string $filePath): void
+    {
+    }
+
+    /**
+     * some comment
+     */
+    public static function dataProvider()
+    {
+        return [
+            ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'],
+            ['<?php implode(\'\', $foo, );', '<?php implode($foo, );']
+        ];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\YieldDataProviderRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class WithComment extends TestCase
+{
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')]
+    public function test(string $filePath): void
+    {
+    }
+
+    /**
+     * some comment
+     */
+    public static function dataProvider(): \Iterator
+    {
+        yield ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'];
+        yield ['<?php implode(\'\', $foo, );', '<?php implode($foo, );'];
+    }
+}
+
+?>