From b488d76be5cc27b6c175836228a1f4e8428d3209 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Mon, 9 Dec 2024 17:50:45 +0100 Subject: [PATCH 1/3] YieldDataProviderRector: added failling test --- .../use_data_provider_with_phpdoc.php.inc | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc diff --git a/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc new file mode 100644 index 00000000..703d4068 --- /dev/null +++ b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc @@ -0,0 +1,61 @@ +> */ + public static function provideDataForProvider() + { + return [ + [' +----- +> */ + public static function provideDataForProvider(): \Iterator + { + yield [' From f9e9f917cf3aeda3c9319856a9d42a118f2335b1 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Mon, 9 Dec 2024 17:51:27 +0100 Subject: [PATCH 2/3] Update use_data_provider_with_phpdoc.php.inc --- .../Fixture/use_data_provider_with_phpdoc.php.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc index 703d4068..048b4d4c 100644 --- a/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc +++ b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc @@ -37,7 +37,7 @@ namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\YieldDataProviderRector use PHPUnit\Framework\TestCase; -final class UseDataProviderTest extends TestCase +final class UseDataProviderTestPhpdoc extends TestCase { #[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')] #[\PHPUnit\Framework\Attributes\DataProvider('provideDataForProvider')] From 85c620d604a782c4bc76bb88e91c7309a34f9622 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Mon, 9 Dec 2024 18:03:33 +0100 Subject: [PATCH 3/3] Update rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc Co-authored-by: Abdul Malik Ikhsan --- .../Fixture/use_data_provider_with_phpdoc.php.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc index 048b4d4c..9866ad0c 100644 --- a/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc +++ b/rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc @@ -4,7 +4,7 @@ namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\YieldDataProviderRector use PHPUnit\Framework\TestCase; -final class UseDataProviderTest extends TestCase +final class UseDataProviderTestPhpdoc extends TestCase { #[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')] #[\PHPUnit\Framework\Attributes\DataProvider('provideDataForProvider')]