[CodeQuality] Skip with if else condition result on AddInstanceofAssertForNullableInstanceRector (#489)

* [CodeQuality] Skip with if else on AddInstanceofAssertForNullableInstanceRector

* update

* update

* update

Author: samsonasik

rules-tests/CodeQuality/Rector/ClassMethod/AddInstanceofAssertForNullableInstanceRector/Fixture/skip_with_if_else.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\AddInstanceofAssertForNullableInstanceRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\AddInstanceofAssertForNullableInstanceRector\Source\SomeClassUsedInTests;
+
+final class SkipWithIfElse extends TestCase
+{
+    public function test(): void
+    {
+        $someObject = $this->getSomeObject();
+        $value = $someObject->getSomeMethod();
+
+        if ($someObject !== null) {
+            $this->assertSame(123, $value);
+
+            // we know the value here, no need to add instanceof
+            $value = $someObject->getSomeMethod();
+        } else {
+            $this->assertNull($someObject);
+        }
+    }
+
+    private function getSomeObject(): ?SomeClassUsedInTests
+    {
+        if (mt_rand(0, 1)) {
+            return new SomeClassUsedInTests();
+        }
+
+        return null;
+    }
+}
+
+?>

rules/CodeQuality/NodeAnalyser/NullableObjectAssignCollector.php

@@ -37,7 +37,7 @@ public function collect(ClassMethod|Foreach_ $stmtsAware): VariableNameToTypeCol
         // first round to collect assigns
         foreach ((array) $stmtsAware->stmts as $stmt) {
             if (! $stmt instanceof Expression) {
-                continue;
+                return new VariableNameToTypeCollection([]);
             }
 
             if (! $stmt->expr instanceof Assign) {

rules/CodeQuality/Rector/MethodCall/AssertTrueFalseToSpecificMethodRector.php

@@ -104,11 +104,10 @@ public function refactor(Node $node): ?Node
         }
 
         if ($firstArgumentName === 'is_a') {
-            /**
-             * @var FuncCall $firstArgumentValue
-             * @var array<Arg> $args
-             **/
+            /** @var FuncCall $firstArgumentValue */
             $args = $firstArgumentValue->getArgs();
+
+            /** @var array<Arg> $args */
             if ($args === []) {
                 return null;
             }