Bump to PHP 8.3 (#605)

* bump to PHP 8.3

* bump deps

* add rector run

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -24,6 +24,18 @@ jobs:
                         name: 'Finalise classes'
                         run: vendor/bin/swiss-knife finalize-classes src rules tests
 
+                    -
+                        name: 'Composer Validate'
+                        run: composer validate
+
+                    -
+                        name: 'PHPStan'
+                        run: vendor/bin/phpstan
+
+                    -
+                        name: 'Tests'
+                        run: vendor/bin/phpunit
+
         name: ${{ matrix.actions.name }}
         runs-on: ubuntu-latest
         timeout-minutes: 10
@@ -34,7 +46,7 @@ jobs:
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             -   uses: "ramsey/composer-install@v2"

.github/workflows/code_analysis_reuslabe.yaml

@@ -0,0 +1,39 @@
+# github action that checks code with Rector
+name: Rector
+
+on:
+    pull_request: null
+
+env:
+    # see https://github.com/composer/composer/issues/9368#issuecomment-718112361
+    COMPOSER_ROOT_VERSION: "dev-main"
+
+jobs:
+    rector:
+        runs-on: ubuntu-latest
+        if: github.event.pull_request.head.repo.full_name == 'rectorphp/rector-phpunit'
+        steps:
+            -
+                if: github.event.pull_request.head.repo.full_name == github.repository
+                uses: actions/checkout@v4
+                with:
+                    # Must be used to trigger workflow after push
+                    token: ${{ secrets.ACCESS_TOKEN }}
+
+            -
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: 8.3
+                    coverage: none
+
+            -   uses: "ramsey/composer-install@v2"
+
+            -   run: vendor/bin/rector --ansi
+
+            -
+                # commit only to core contributors who have repository access
+                uses: stefanzweifel/git-auto-commit-action@v4
+                with:
+                    commit_message: '[rector] Rector fixes'
+                    commit_author: 'GitHub Action <actions@github.com>'
+                    commit_user_email: 'action@github.com'

.github/workflows/rector.yaml.yml

@@ -15,8 +15,6 @@ jobs:
         steps:
             - uses: actions/checkout@v4
 
-
-
             - name: "Check for typos"
               uses: "crate-ci/typos@v1.40.0"
               with:

.github/workflows/tests.yaml

@@ -4,23 +4,23 @@
     "license": "MIT",
     "description": "Rector upgrades rules for PHPUnit",
     "require": {
-        "php": ">=8.2"
+        "php": ">=8.3"
     },
     "require-dev": {
-        "phpecs/phpecs": "^2.2",
+        "symplify/easy-coding-standard": "^13.0",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.1.31",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-webmozart-assert": "^2.0",
-        "phpunit/phpunit": "^11.5",
-        "rector/jack": "^0.4.0",
+        "phpunit/phpunit": "^11.5|^12.0",
+        "rector/jack": "^0.5",
         "rector/rector-src": "dev-main",
-        "rector/swiss-knife": "^1.0",
+        "rector/swiss-knife": "^2.0",
         "rector/type-perfect": "^2.1",
         "symplify/phpstan-extensions": "^12.0",
         "symplify/phpstan-rules": "^14.9",
-        "symplify/vendor-patches": "^11.5",
-        "tomasvotruba/class-leak": "^1.2",
+        "symplify/vendor-patches": "^11.0",
+        "tomasvotruba/class-leak": "^2.1",
         "tracy/tracy": "^2.11"
     },
     "autoload": {

.github/workflows/typos.yaml

@@ -30,10 +30,7 @@
  */
 final class DataProviderAnnotationToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const DATA_PROVIDER_CLASS = 'PHPUnit\Framework\Attributes\DataProvider';
+    private const string DATA_PROVIDER_CLASS = 'PHPUnit\Framework\Attributes\DataProvider';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,

composer.json

@@ -27,10 +27,7 @@
  */
 final class DependsAnnotationWithValueToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const DEPENDS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\Depends';
+    private const string DEPENDS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\Depends';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,

rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php

@@ -30,10 +30,7 @@
  */
 final class TestWithAnnotationToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const TEST_WITH_ATTRIBUTE = 'PHPUnit\Framework\Attributes\TestWith';
+    private const string TEST_WITH_ATTRIBUTE = 'PHPUnit\Framework\Attributes\TestWith';
 
     public function __construct(
         private readonly TestsNodeAnalyzer $testsNodeAnalyzer,

rules/AnnotationsToAttributes/Rector/ClassMethod/DependsAnnotationWithValueToAttributeRector.php

@@ -28,25 +28,13 @@
  */
 final class CoversAnnotationWithValueToAttributeRector extends AbstractRector implements MinPhpVersionInterface
 {
-    /**
-     * @var string
-     */
-    private const COVERS_FUNCTION_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversFunction';
+    private const string COVERS_FUNCTION_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversFunction';
 
-    /**
-     * @var string
-     */
-    private const COVERTS_CLASS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversClass';
+    private const string COVERTS_CLASS_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversClass';
 
-    /**
-     * @var string
-     */
-    private const COVERTS_TRAIT_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversTrait';
+    private const string COVERTS_TRAIT_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversTrait';
 
-    /**
-     * @var string
-     */
-    private const COVERS_METHOD_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversMethod';
+    private const string COVERS_METHOD_ATTRIBUTE = 'PHPUnit\Framework\Attributes\CoversMethod';
 
     public function __construct(
         private readonly PhpDocTagRemover $phpDocTagRemover,