[CodeQuality] Skip not match position named argument on ScalarArgumentToExpectedParamTypeRector

Author: samsonasik

rules-tests/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector/Fixture/skip_not_match_position_named_argument.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\ScalarArgumentToExpectedParamTypeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipNotMatchPositionNamedArgument extends TestCase
+{
+    public function testSomething()
+    {
+        self::assertJsonResponse(contentType: 'text/html');
+    }
+
+    protected static function assertJsonResponse(int $statusCode = 200, string $contentType = 'application/json'): void
+    {
+		// logic
+    }
+}

rules/CodeQuality/Rector/MethodCall/ScalarArgumentToExpectedParamTypeRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Scalar;
 use PhpParser\Node\Scalar\Float_;
 use PhpParser\Node\Scalar\Int_;
@@ -101,13 +102,24 @@ public function refactor(Node $node): ?Node
 
         $hasChanged = false;
         $callParameterTypes = $this->methodParametersAndReturnTypesResolver->resolveCallParameterTypes($node);
+        $callParameterNames = $this->methodParametersAndReturnTypesResolver->resolveCallParameterNames($node);
 
         foreach ($node->getArgs() as $key => $arg) {
             if (! $arg->value instanceof Scalar) {
                 continue;
             }
 
             $knownParameterType = $callParameterTypes[$key] ?? null;
+            if ($arg->name instanceof Identifier) {
+                $argName = $arg->name->toString();
+                foreach ($callParameterNames as $keyParameterNames => $callParameterName) {
+                    if ($argName === $callParameterName) {
+                        $knownParameterType = $callParameterTypes[$keyParameterNames] ?? null;
+                        break;
+                    }
+                }
+            }
+
             if (! $knownParameterType instanceof Type) {
                 continue;
             }

rules/CodeQuality/Reflection/MethodParametersAndReturnTypesResolver.php

@@ -89,6 +89,52 @@ public function resolveCallParameterTypes(MethodCall|StaticCall $call): ?array
         return $this->resolveParameterTypes($extendedMethodReflection, $classReflection);
     }
 
+        /**
+     * @return null|Type[]
+     */
+    public function resolveCallParameterNames(MethodCall|StaticCall $call): ?array
+    {
+        if (! $call->name instanceof Identifier) {
+            return null;
+        }
+
+        $methodName = $call->name->toString();
+
+        $callerType = $this->nodeTypeResolver->getType($call instanceof MethodCall ? $call->var : $call->class);
+        if (! $callerType instanceof ObjectType) {
+            return null;
+        }
+
+        $classReflection = $callerType->getClassReflection();
+        if (! $classReflection instanceof ClassReflection) {
+            return null;
+        }
+
+        if (! $classReflection->hasNativeMethod($methodName)) {
+            return null;
+        }
+
+        $extendedMethodReflection = $classReflection->getNativeMethod($methodName);
+        return $this->resolveParameterNames($extendedMethodReflection);
+    }
+
+    /**
+     * @return string[]
+     */
+    private function resolveParameterNames(ExtendedMethodReflection $extendedMethodReflection): array
+    {
+        $extendedParametersAcceptor = ParametersAcceptorSelector::combineAcceptors(
+            $extendedMethodReflection->getVariants()
+        );
+
+        $parameterNames = [];
+        foreach ($extendedParametersAcceptor->getParameters() as $parameterReflection) {
+            $parameterNames[] = $parameterReflection->getName();
+        }
+
+        return $parameterNames;
+    }
+
     /**
      * @return Type[]
      */