Fix argument.type PHPStan errors (#553)

* Fix invalid argument type PHPStan errors

* fix cs

* remove ignore

* fix

* cs

* run rector

* cs

* fix another ignored error

* Update phpstan.neon

Author: staabm

phpstan.neon

@@ -34,21 +34,12 @@ parameters:
         # false positive
         - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
 
-        - '#PhpParser\\Node\\Stmt\\Expression is not generic#'
-
         # more advanced usage, but not always working
         # see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110
         - '#Doing instanceof PHPStan\\Type\\.+ is error\-prone and deprecated#'
 
         -
             identifier: instanceof.alwaysTrue
 
-        -
-            identifier: argument.type
-
         -
             identifier: assign.propertyType
-
-        -
-            message: '#Cannot call method getName\(\) on PHPStan\\Reflection\\ClassReflection\|null#'
-            path: rules/CodeQuality/Reflection/MethodParametersAndReturnTypesResolver.php

rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php

@@ -143,7 +143,12 @@ public function refactor(Node $node): ?Node
                 $originalAttributeValue = $desiredTagValueNode->value->getOriginalContent();
             }
 
-            $node->attrGroups[] = $this->createAttributeGroup(strtok($originalAttributeValue, " \t\n\r\0\x0B"));
+            $originalAttributeValueToken = strtok($originalAttributeValue ?: '', " \t\n\r\0\x0B");
+            if ($originalAttributeValueToken === false) {
+                continue;
+            }
+
+            $node->attrGroups[] = $this->createAttributeGroup($originalAttributeValueToken);
 
             // cleanup
             $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $desiredTagValueNode);

rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php

@@ -73,6 +73,9 @@ public function detectTestCaseCallForStatic(MethodCall $methodCall): bool
     private function resolveMethodReflection(MethodCall|StaticCall $call): ?ExtendedMethodReflection
     {
         $methodName = $this->nodeNameResolver->getName($call->name);
+        if ($methodName === null) {
+            return null;
+        }
 
         $classReflection = $this->reflectionResolver->resolveClassReflection($call);
         if (! $classReflection instanceof ClassReflection) {

rules/CodeQuality/NodeAnalyser/NullableObjectAssignCollector.php

@@ -73,6 +73,10 @@ private function collectFromAssign(Assign $assign): ?VariableNameToType
         }
 
         $variableName = $this->nodeNameResolver->getName($assign->var);
+        if (! is_string($variableName)) {
+            return null;
+        }
+
         return new VariableNameToType($variableName, $bareVariableType->getClassName());
     }
 }

rules/CodeQuality/Rector/ClassMethod/AddInstanceofAssertForNullableInstanceRector.php

@@ -197,9 +197,12 @@ private function matchedNullableVariableNameToType(
                 return null;
             }
 
-            $matchedNullableVariableNameToType = $variableNameToTypeCollection->matchByVariableName(
-                $this->getName($node->var)
-            );
+            $variableName = $this->getName($node->var);
+            if ($variableName === null) {
+                return null;
+            }
+
+            $matchedNullableVariableNameToType = $variableNameToTypeCollection->matchByVariableName($variableName);
 
             // is the variable we're interested in?
             return null;

rules/CodeQuality/Rector/ClassMethod/CreateMockToAnonymousClassRector.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\New_;
+use PhpParser\Node\Name;
 use PhpParser\Node\Scalar;
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt;
@@ -200,6 +201,10 @@ private function createAnonymousClass(Arg $firstArg): Class_
             throw new NotImplementedYetException();
         }
 
+        if (! $className instanceof Name) {
+            throw new NotImplementedYetException();
+        }
+
         // must respect PHPStan anonymous internal naming \Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver::ANONYMOUS_CLASS_START_REGEX
         return new Class_('AnonymousClass1234', [
             'extends' => $className,

rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php

@@ -110,6 +110,9 @@ public function refactor(Node $node): ?Node
             }
 
             $soleReturnExpr = $returns[0]->expr;
+            if ($soleReturnExpr === null) {
+                continue;
+            }
 
             // does return a type?
             $returnedExprType = $this->nodeTypeResolver->getNativeType($soleReturnExpr);

rules/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector.php

@@ -88,6 +88,9 @@ public function refactor(Node $node): ?Node
             }
 
             $methodName = $this->getName($node->name);
+            if ($methodName === null) {
+                return null;
+            }
 
             $hasChanged = true;
             return $this->nodeFactory->createStaticCall('self', $methodName, $node->getArgs());

rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php

@@ -98,6 +98,9 @@ public function refactor(Node $node): ?Node
             }
 
             $methodName = $this->getName($node->name);
+            if ($methodName === null) {
+                return null;
+            }
 
             $hasChanged = true;
             return $this->nodeFactory->createMethodCall('this', $methodName, $node->getArgs());

rules/CodeQuality/Rector/Class_/TypeWillReturnCallableArrowFunctionRector.php

@@ -235,8 +235,13 @@ public function refactor(Node $node): ?Class_
             }
 
             if (! $innerClosure->returnType instanceof Node) {
+                $returnType = $parameterTypesAndReturnType->getReturnType();
+                if (! $returnType instanceof Type) {
+                    return null;
+                }
+
                 $returnTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
-                    $parameterTypesAndReturnType->getReturnType(),
+                    $returnType,
                     TypeKind::RETURN
                 );