Fix invalid argument type PHPStan errors

Author: staabm

phpstan.neon

@@ -43,9 +43,6 @@ parameters:
         -
             identifier: instanceof.alwaysTrue
 
-        -
-            identifier: argument.type
-
         -
             identifier: assign.propertyType
 

rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php

@@ -143,7 +143,11 @@ public function refactor(Node $node): ?Node
                 $originalAttributeValue = $desiredTagValueNode->value->getOriginalContent();
             }
 
-            $node->attrGroups[] = $this->createAttributeGroup(strtok($originalAttributeValue, " \t\n\r\0\x0B"));
+            $originalAttributeValueToken = strtok($originalAttributeValue ?: '', " \t\n\r\0\x0B");
+            if ($originalAttributeValueToken === false) {
+                continue;
+            }
+            $node->attrGroups[] = $this->createAttributeGroup($originalAttributeValueToken);
 
             // cleanup
             $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $desiredTagValueNode);

rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php

@@ -73,6 +73,9 @@ public function detectTestCaseCallForStatic(MethodCall $methodCall): bool
     private function resolveMethodReflection(MethodCall|StaticCall $call): ?ExtendedMethodReflection
     {
         $methodName = $this->nodeNameResolver->getName($call->name);
+        if ($methodName === null) {
+            return null;
+        }
 
         $classReflection = $this->reflectionResolver->resolveClassReflection($call);
         if (! $classReflection instanceof ClassReflection) {

rules/CodeQuality/NodeAnalyser/NullableObjectAssignCollector.php

@@ -73,6 +73,10 @@ private function collectFromAssign(Assign $assign): ?VariableNameToType
         }
 
         $variableName = $this->nodeNameResolver->getName($assign->var);
+        if (! is_string($variableName)) {
+            return null;
+        }
+
         return new VariableNameToType($variableName, $bareVariableType->getClassName());
     }
 }

rules/CodeQuality/Rector/ClassMethod/AddInstanceofAssertForNullableInstanceRector.php

@@ -197,8 +197,13 @@ private function matchedNullableVariableNameToType(
                 return null;
             }
 
+            $variableName = $this->getName($node->var);
+            if ($variableName === null) {
+                return null;
+            }
+
             $matchedNullableVariableNameToType = $variableNameToTypeCollection->matchByVariableName(
-                $this->getName($node->var)
+                $variableName
             );
 
             // is the variable we're interested in?

rules/CodeQuality/Rector/ClassMethod/CreateMockToAnonymousClassRector.php

@@ -201,7 +201,7 @@ private function createAnonymousClass(Arg $firstArg): Class_
         }
 
         // must respect PHPStan anonymous internal naming \Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver::ANONYMOUS_CLASS_START_REGEX
-        return new Class_('AnonymousClass1234', [
+        return new Class_('AnonymousClass1234', [ // @phpstan-ignore argument.type
             'extends' => $className,
         ], [
             'startLine' => $firstArg->getStartLine(),

rules/CodeQuality/Rector/Class_/AddReturnTypeToDependedRector.php

@@ -110,6 +110,9 @@ public function refactor(Node $node): ?Node
             }
 
             $soleReturnExpr = $returns[0]->expr;
+            if ($soleReturnExpr === null) {
+                continue;
+            }
 
             // does return a type?
             $returnedExprType = $this->nodeTypeResolver->getNativeType($soleReturnExpr);

rules/CodeQuality/Rector/Class_/PreferPHPUnitSelfCallRector.php

@@ -88,6 +88,9 @@ public function refactor(Node $node): ?Node
             }
 
             $methodName = $this->getName($node->name);
+            if ($methodName === null) {
+                return null;
+            }
 
             $hasChanged = true;
             return $this->nodeFactory->createStaticCall('self', $methodName, $node->getArgs());

rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php

@@ -98,6 +98,9 @@ public function refactor(Node $node): ?Node
             }
 
             $methodName = $this->getName($node->name);
+            if ($methodName === null) {
+                return null;
+            }
 
             $hasChanged = true;
             return $this->nodeFactory->createMethodCall('this', $methodName, $node->getArgs());

rules/CodeQuality/Rector/Class_/TypeWillReturnCallableArrowFunctionRector.php

@@ -235,8 +235,13 @@ public function refactor(Node $node): ?Class_
             }
 
             if (! $innerClosure->returnType instanceof Node) {
+                $returnType = $parameterTypesAndReturnType->getReturnType();
+                if ($returnType === null) {
+                    return null;
+                }
+
                 $returnTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
-                    $parameterTypesAndReturnType->getReturnType(),
+                    $returnType,
                     TypeKind::RETURN
                 );