Skip to content

Commit 761945f

Browse files
committed
register AssertFuncCallToPHPUnitAssertRector in code-quality set
1 parent 11424b1 commit 761945f

File tree

2 files changed

+31
-2
lines changed

2 files changed

+31
-2
lines changed

config/sets/phpunit-code-quality.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\ReplaceTestAnnotationWithPrefixedFunctionRector;
2020
use Rector\PHPUnit\CodeQuality\Rector\Expression\AssertArrayCastedObjectToAssertSameRector;
2121
use Rector\PHPUnit\CodeQuality\Rector\Foreach_\SimplifyForeachInstanceOfRector;
22+
use Rector\PHPUnit\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector;
2223
use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertCompareOnCountableWithMethodToAssertCountRector;
2324
use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector;
2425
use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector;
@@ -91,6 +92,7 @@
9192
AssertInstanceOfComparisonRector::class,
9293
AssertPropertyExistsRector::class,
9394
AssertRegExpRector::class,
95+
AssertFuncCallToPHPUnitAssertRector::class,
9496
SimplifyForeachInstanceOfRector::class,
9597
UseSpecificWillMethodRector::class,
9698
UseSpecificWithMethodRector::class,

rules/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector.php

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,35 @@ public function __construct(
3939

4040
public function getRuleDefinition(): RuleDefinition
4141
{
42-
return new RuleDefinition('Turns assert() calls to their explicit PHPUnit assert alternative', [
43-
new CodeSample('assert($value === 100, "message");', '$this->assertSame(100, $value, "message");'),
42+
return new RuleDefinition('Turns assert() calls in tests to PHPUnit assert method alternative', [
43+
new CodeSample(
44+
<<<'CODE_SAMPLE'
45+
use PHPUnit\Framework\TestCase;
46+
47+
class SomeClass extends TestCase
48+
{
49+
public function test()
50+
{
51+
$value = 1000;
52+
assert($value === 1000, 'message');
53+
}
54+
}
55+
CODE_SAMPLE
56+
,
57+
<<<'CODE_SAMPLE'
58+
use PHPUnit\Framework\TestCase;
59+
60+
class SomeClass extends TestCase
61+
{
62+
public function test()
63+
{
64+
$value = 1000;
65+
66+
$this->assertSame(1000, $value, "message")
67+
}
68+
}
69+
CODE_SAMPLE
70+
),
4471
]);
4572
}
4673

0 commit comments

Comments
 (0)