Add non-testcase assert call in FlipAssertRector (#446)

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector/Fixture/skip.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\FlipAssertRector\Fixture;
+
+use PHPUnit\Framework\Assert;
+
+final class CovertExternalStaticCall
+{
+    public function test()
+    {
+        $result = '...';
+        Assert::assertStringContainsString($result, 'expected');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\FlipAssertRector\Fixture;
+
+use PHPUnit\Framework\Assert;
+
+final class CovertExternalStaticCall
+{
+    public function test()
+    {
+        $result = '...';
+        Assert::assertStringContainsString('expected', $result);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/FlipAssertRector/Fixture/cover_external_static_call.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Enum;
+
+final class PHPUnitClassName
+{
+    /**
+     * @var string
+     */
+    public const TEST_CASE = 'PHPUnit\Framework\TestCase';
+
+    /**
+     * @var string
+     */
+    public const ASSERT = 'PHPUnit\Framework\Assert';
+}

src/Enum/PHPUnitClassName.php

@@ -13,6 +13,7 @@
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver;
+use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\Reflection\ReflectionResolver;
 
 final readonly class TestsNodeAnalyzer
@@ -96,10 +97,23 @@ public function isPHPUnitMethodCallNames(Node $node, array $names): bool
 
     public function isPHPUnitTestCaseCall(Node $node): bool
     {
-        if (! $this->isInTestClass($node)) {
-            return false;
+        if ($node instanceof MethodCall) {
+            return $this->isInTestClass($node);
+        }
+
+        if ($node instanceof StaticCall) {
+            $classType = $this->nodeTypeResolver->getType($node->class);
+            if ($classType instanceof ObjectType) {
+                if ($classType->isInstanceOf(PHPUnitClassName::TEST_CASE)->yes()) {
+                    return true;
+                }
+
+                if ($classType->isInstanceOf(PHPUnitClassName::ASSERT)->yes()) {
+                    return true;
+                }
+            }
         }
 
-        return $node instanceof MethodCall || $node instanceof StaticCall;
+        return false;
     }
 }