[AssertCompareToSpecificMethodRector ] Remove inversion of parameters in Assert calls (#423)

* Remove inversion of parameters

* Refacto

Author: VincentLanglet

rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/get_class.php.inc

@@ -9,7 +9,6 @@ final class GetClass extends \PHPUnit\Framework\TestCase
     public function test()
     {
         $something = new stdClass();
-        $this->assertSame(get_class($something), 'stdClass');
         self::assertSame('stdClass', get_class($something));
     }
 }
@@ -27,7 +26,6 @@ final class GetClass extends \PHPUnit\Framework\TestCase
     public function test()
     {
         $something = new stdClass();
-        $this->assertInstanceOf('stdClass', $something);
         self::assertInstanceOf('stdClass', $something);
     }
 }

rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_first_param.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertCompareToSpecificMethodRector\Fixture;
+
+final class SkipFirstParam extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $this->assertSame(count($something), 5);
+        $this->assertSame(get_class($something), 'stdClass');
+    }
+}
+
+?>
+    -----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertCompareToSpecificMethodRector\Fixture;
+
+final class SkipFirstParam extends \PHPUnit\Framework\TestCase
+{
+    public function test()
+    {
+        $this->assertSame(count($something), 5);
+        $this->assertSame(get_class($something), 'stdClass');
+    }
+}
+
+?>

rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php

@@ -57,7 +57,7 @@ public function getRuleDefinition(): RuleDefinition
                     '$this->assertCount(10, $anything, "message");'
                 ),
                 new CodeSample(
-                    '$this->assertNotEquals(get_class($value), SomeInstance::class);',
+                    '$this->assertNotEquals(SomeInstance::class, get_class($value));',
                     '$this->assertNotInstanceOf(SomeInstance::class, $value);'
                 ),
             ]
@@ -95,18 +95,12 @@ public function refactor(Node $node): ?Node
 
         $firstArgument = $node->getArgs()[0];
         $secondArgument = $node->getArgs()[1];
-
-        $firstArgumentValue = $firstArgument->value;
         $secondArgumentValue = $secondArgument->value;
 
         if ($secondArgumentValue instanceof FuncCall) {
             return $this->processFuncCallArgumentValue($node, $secondArgumentValue, $firstArgument);
         }
 
-        if ($firstArgumentValue instanceof FuncCall) {
-            return $this->processFuncCallArgumentValue($node, $firstArgumentValue, $secondArgument);
-        }
-
         return null;
     }