Detect Test Attribute in TestsNodeAnalyzer::isTestClassMethod (#486)

* detect Test Attribute in TestsNodeAnalyzer::isTestClassMethod

* swap `array_any` to traditional foreach

* add tests for AddTestsVoidReturnTypeWhereNoReturnRector

* fix style

* run rector

* also check protected method while we're at it

* add isTest tests with php attributes for existing rector rules

* fix classname for test fixtures

Author: Levivb

rules-tests/AnnotationsToAttributes/Rector/ClassMethod/TestWithAnnotationToAttributeRector/Fixture/some_fixture_with_test_attribute.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\ClassMethod\TestWithAnnotationToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SomeFixtureWithTestAttribute extends TestCase
+{
+    /**
+     * @testWith ["foo"]
+     *           ["bar"]
+     */
+    #[\PHPUnit\Framework\Attributes\Test]
+    public function shouldDoSomething(): void
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\AnnotationsToAttributes\Rector\ClassMethod\TestWithAnnotationToAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SomeFixtureWithTestAttribute extends TestCase
+{
+    #[\PHPUnit\Framework\Attributes\Test]
+    #[\PHPUnit\Framework\Attributes\TestWith(['foo'])]
+    #[\PHPUnit\Framework\Attributes\TestWith(['bar'])]
+    public function shouldDoSomething(): void
+    {
+    }
+}
+
+?>

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/test_in_annotation.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
-class TestInAnnotatoin extends \PHPUnit\Framework\TestCase
+class TestInAnnotation extends \PHPUnit\Framework\TestCase
 {
     /**
      * @test
@@ -19,7 +19,7 @@ class TestInAnnotatoin extends \PHPUnit\Framework\TestCase
 
 namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
-class TestInAnnotatoin extends \PHPUnit\Framework\TestCase
+class TestInAnnotation extends \PHPUnit\Framework\TestCase
 {
     /**
      * @test

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/test_in_annotation_with_test_attribute.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+class TestInAnnotationWithTestAttribute extends \PHPUnit\Framework\TestCase
+{
+    #[\PHPUnit\Framework\Attributes\Test]
+    public function thisIsTest()
+    {
+        $nothing = 5;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+class TestInAnnotationWithTestAttribute extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @doesNotPerformAssertions
+     */
+    #[\PHPUnit\Framework\Attributes\Test]
+    public function thisIsTest()
+    {
+        $nothing = 5;
+    }
+}
+
+?>

src/NodeAnalyzer/TestsNodeAnalyzer.php

@@ -58,6 +58,14 @@ public function isTestClassMethod(ClassMethod $classMethod): bool
             return true;
         }
 
+        foreach ($classMethod->getAttrGroups() as $attributeGroup) {
+            foreach ($attributeGroup->attrs as $attribute) {
+                if ($attribute->name->toString() === 'PHPUnit\\Framework\\Attributes\\Test') {
+                    return true;
+                }
+            }
+        }
+
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);
         return $phpDocInfo->hasByName('test');
     }