From 614926e5f6277366e7aa9e9e3ff8367c75e28036 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Wed, 3 Dec 2025 00:51:54 +0100
Subject: [PATCH] simplify DowngradeIteratorCountToArrayRector

---
 phpstan.neon                                  |  4 ----
 .../Fixture/skip_in_ternary.php.inc           | 16 -------------
 .../DowngradeIteratorCountToArrayRector.php   | 23 ++-----------------
 3 files changed, 2 insertions(+), 41 deletions(-)
 delete mode 100644 rules-tests/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector/Fixture/skip_in_ternary.php.inc

diff --git a/phpstan.neon b/phpstan.neon
index 306b1226..be0a8de4 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -99,7 +99,3 @@ parameters:
         -
             identifier: symplify.seeAnnotationToTest
             path:  rules/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector.php
-
-        -
-            identifier: rector.noIntegerRefactorReturn
-            path:  rules/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector.php
diff --git a/rules-tests/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector/Fixture/skip_in_ternary.php.inc b/rules-tests/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector/Fixture/skip_in_ternary.php.inc
deleted file mode 100644
index e36ee42b..00000000
--- a/rules-tests/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector/Fixture/skip_in_ternary.php.inc
+++ /dev/null
@@ -1,16 +0,0 @@
-<?php
-
-namespace Rector\Tests\DowngradePhp82\Rector\FuncCall\DowngradeIteratorCountToArrayRector\Fixture;
-
-final class SkipInternary
-{
-    public function run($taggedServices)
-    {
-        return \is_array($taggedServices) ? $taggedServices : \iterator_to_array($taggedServices);
-    }
-
-    public function run2($taggedServices)
-    {
-        return ! \is_array($taggedServices) ? \iterator_to_array($taggedServices): $taggedServices;
-    }
-}
diff --git a/rules/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector.php b/rules/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector.php
index 262cd753..e4044dbb 100644
--- a/rules/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector.php
+++ b/rules/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector.php
@@ -10,11 +10,9 @@
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Name\FullyQualified;
-use PhpParser\NodeVisitor;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
-use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -30,7 +28,6 @@ final class DowngradeIteratorCountToArrayRector extends AbstractRector
 {
     public function __construct(
         private readonly ArgsAnalyzer $argsAnalyzer,
-        private readonly BetterNodeFinder $betterNodeFinder
     ) {
     }
 
@@ -67,26 +64,10 @@ function test(array|Traversable $data) {
     }
 
     /**
-     * @param Ternary|FuncCall $node
-     * @return null|FuncCall|NodeVisitor::DONT_TRAVERSE_CHILDREN
+     * @param FuncCall $node
      */
-    public function refactor(Node $node): null|FuncCall|int
+    public function refactor(Node $node): null|FuncCall
     {
-        if ($node instanceof Ternary) {
-            $hasIsArrayCheck = (bool) $this->betterNodeFinder->findFirst(
-                $node,
-                fn (Node $subNode): bool => $subNode instanceof FuncCall && $this->isName($subNode, 'is_array')
-            );
-
-            // get tgype...
-
-            if ($hasIsArrayCheck) {
-                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
-            }
-
-            return null;
-        }
-
         if (! $this->isNames($node, ['iterator_count', 'iterator_to_array'])) {
             return null;
         }