From 949a99b98710602c4321d8d1ee4ea3716e64334d Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 9 Sep 2025 19:04:04 +0700 Subject: [PATCH 1/2] Only add Override for now for skipped attributes --- .../Rector/Class_/DowngradeAttributeToAnnotationRector.php | 1 - 1 file changed, 1 deletion(-) diff --git a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php index 6a776e27..1ad85833 100644 --- a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php +++ b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php @@ -39,7 +39,6 @@ final class DowngradeAttributeToAnnotationRector extends AbstractRector implemen 'ReturnTypeWillChange', 'AllowDynamicProperties', 'Override', - 'SensitiveParameter', ]; /** From b8757ab4222b5b7683d0f73463dbdc8ba7b9d84d Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Tue, 9 Sep 2025 12:05:12 +0000 Subject: [PATCH 2/2] [ci-review] Rector Rectify --- .../Rector/Class_/DowngradeAttributeToAnnotationRector.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php index 1ad85833..f4509687 100644 --- a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php +++ b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php @@ -34,12 +34,7 @@ final class DowngradeAttributeToAnnotationRector extends AbstractRector implemen /** * @var string[] */ - private const SKIPPED_ATTRIBUTES = [ - 'Attribute', - 'ReturnTypeWillChange', - 'AllowDynamicProperties', - 'Override', - ]; + private const SKIPPED_ATTRIBUTES = ['Attribute', 'ReturnTypeWillChange', 'AllowDynamicProperties', 'Override']; /** * @var DowngradeAttributeToAnnotation[]