From 253088e49a662540528e3a201b93c756651756a6 Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Mon, 8 Sep 2025 20:52:04 +0700
Subject: [PATCH 1/2] [DowngradePhp85] Handle implicit public on
 DowngradePropertyPromotionRector

---
 ...hp => implicit_final_property_promotion.php.inc} | 13 +++++++------
 .../DowngradeFinalPropertyPromotionRector.php       |  4 ++++
 2 files changed, 11 insertions(+), 6 deletions(-)
 rename rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/{implicit_final_property_promotion.php => implicit_final_property_promotion.php.inc} (78%)

diff --git a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc
similarity index 78%
rename from rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php
rename to rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc
index c048a413..2f137823 100644
--- a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php
+++ b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc
@@ -7,6 +7,7 @@ public function __construct(final string $foo)
     {
     }
 }
+
 ?>
 -----
 <?php
@@ -14,12 +15,12 @@ public function __construct(final string $foo)
 
 class ImplicitFinalPropertyPromotion
 {
-    public function __construct(
-         /**
-           * @final
-           */
-         public string $foo
-    )
+    public function __construct(/**
+     * @final
+     */
+    public string $foo)
     {
     }
 }
+
+?>
diff --git a/rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php b/rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php
index 91e55a7d..c1b5488b 100644
--- a/rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php
+++ b/rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php
@@ -95,6 +95,10 @@ public function refactor(Node $node): ?ClassMethod
             $hasChanged = true;
             $this->visibilityManipulator->makeNonFinal($param);
 
+            if (! $param->isPromoted()) {
+                $this->visibilityManipulator->makePublic($param);
+            }
+
             $this->addPhpDocTag($param);
 
         }

From 8e8a91ee8430f5e59a7241b5ced512e7b3baccc4 Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Mon, 8 Sep 2025 20:53:48 +0700
Subject: [PATCH 2/2] namespace chagne

---
 .../Fixture/fixture.php.inc                                 | 4 ++--
 .../Fixture/implicit_final_property_promotion.php.inc       | 6 ++++--
 .../Fixture/skip_fixture_readonly.php.inc                   | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/fixture.php.inc b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/fixture.php.inc
index d03193fd..eb8ba7a2 100644
--- a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/fixture.php.inc
+++ b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/fixture.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DowngradeFinalPropertyPromotionRector\Rector\Class_\DowngradePropertyPromotionRector\Fixture;
+namespace Rector\Tests\DowngradePhp85\Rector\Class_\DowngradeFinalPropertyPromotionRector\Fixture;
 
 class Fixture
 {
@@ -13,7 +13,7 @@ class Fixture
 -----
 <?php
 
-namespace Rector\Tests\DowngradeFinalPropertyPromotionRector\Rector\Class_\DowngradePropertyPromotionRector\Fixture;
+namespace Rector\Tests\DowngradePhp85\Rector\Class_\DowngradeFinalPropertyPromotionRector\Fixture;
 
 class Fixture
 {
diff --git a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc
index 2f137823..712c0252 100644
--- a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc
+++ b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/implicit_final_property_promotion.php.inc
@@ -1,5 +1,6 @@
 <?php
-namespace Rector\Tests\DowngradeFinalPropertyPromotionRector\Rector\Class_\DowngradePropertyPromotionRector\Fixture;
+
+namespace Rector\Tests\DowngradePhp85\Rector\Class_\DowngradeFinalPropertyPromotionRector\Fixture;
 
 class ImplicitFinalPropertyPromotion
 {
@@ -11,7 +12,8 @@ class ImplicitFinalPropertyPromotion
 ?>
 -----
 <?php
-namespace Rector\Tests\DowngradeFinalPropertyPromotionRector\Rector\Class_\DowngradePropertyPromotionRector\Fixture;
+
+namespace Rector\Tests\DowngradePhp85\Rector\Class_\DowngradeFinalPropertyPromotionRector\Fixture;
 
 class ImplicitFinalPropertyPromotion
 {
diff --git a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/skip_fixture_readonly.php.inc b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/skip_fixture_readonly.php.inc
index a705e4fe..f1cf471c 100644
--- a/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/skip_fixture_readonly.php.inc
+++ b/rules-tests/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector/Fixture/skip_fixture_readonly.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DowngradeFinalPropertyPromotionRector\Rector\Class_\DowngradePropertyPromotionRector\Fixture;
+namespace Rector\Tests\DowngradePhp85\Rector\Class_\DowngradeFinalPropertyPromotionRector\Fixture;
 
 class SkipFixtureReadonly
 {