From c8ae2279abfe09d782f234dcdae35d73cb898a7c Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 8 Sep 2025 14:06:11 +0700 Subject: [PATCH] [DowngradePhp80] Register Override and SensitiveParameter to skipped attributes on DowngradeAttributeToAnnotationRector --- .../override_and_sensitive_parameters.php.inc | 40 +++++++++++++++++++ .../DowngradeAttributeToAnnotationRector.php | 8 +++- 2 files changed, 47 insertions(+), 1 deletion(-) create mode 100644 rules-tests/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector/Fixture/override_and_sensitive_parameters.php.inc diff --git a/rules-tests/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector/Fixture/override_and_sensitive_parameters.php.inc b/rules-tests/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector/Fixture/override_and_sensitive_parameters.php.inc new file mode 100644 index 00000000..8765fcdc --- /dev/null +++ b/rules-tests/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector/Fixture/override_and_sensitive_parameters.php.inc @@ -0,0 +1,40 @@ +isTrue($param)) { + return 5; + } + + return '10'; + } + + private function isTrue($value) { + return $value === true; + } +} + +?> +----- +isTrue($param)) { + return 5; + } + + return '10'; + } + + private function isTrue($value) { + return $value === true; + } +} + +?> \ No newline at end of file diff --git a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php index c20e2f00..e05154ca 100644 --- a/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php +++ b/rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php @@ -34,7 +34,13 @@ final class DowngradeAttributeToAnnotationRector extends AbstractRector implemen /** * @var string[] */ - private const SKIPPED_ATTRIBUTES = ['Attribute', 'ReturnTypeWillChange', 'AllowDynamicProperties']; + private const SKIPPED_ATTRIBUTES = [ + 'Attribute', + 'ReturnTypeWillChange', + 'AllowDynamicProperties', + 'Override', + 'SensitiveParameter', + ]; /** * @var DowngradeAttributeToAnnotation[]