diff --git a/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php b/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php index 0f096865..54e2beec 100644 --- a/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php +++ b/rules/DowngradePhp80/NodeAnalyzer/NamedToUnnamedArgs.php @@ -56,7 +56,7 @@ public function fillFromNamedArgs( $currentArg->value, $currentArg->byRef, $currentArg->unpack, - $currentArg->getAttributes(), + [], null ); } diff --git a/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php b/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php index 38c9e830..68e7b47d 100644 --- a/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php +++ b/rules/DowngradePhp80/NodeAnalyzer/UnnamedArgumentResolver.php @@ -45,7 +45,7 @@ public function resolveFromReflection( foreach ($currentArgs as $key => $arg) { if (! $arg->name instanceof Identifier) { - $unnamedArgs[$key] = new Arg($arg->value, $arg->byRef, $arg->unpack, $arg->getAttributes(), null); + $unnamedArgs[$key] = new Arg($arg->value, $arg->byRef, $arg->unpack, [], null); continue; } diff --git a/tests/Issues/DowngradeNamedTrailing/DowngradeNamedTrailingTest.php b/tests/Issues/DowngradeNamedTrailing/DowngradeNamedTrailingTest.php new file mode 100644 index 00000000..c142a5c8 --- /dev/null +++ b/tests/Issues/DowngradeNamedTrailing/DowngradeNamedTrailingTest.php @@ -0,0 +1,28 @@ +doTestFile($filePath); + } + + public static function provideData(): Iterator + { + return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); + } + + public function provideConfigFilePath(): string + { + return __DIR__ . '/config/configured_rule.php'; + } +} diff --git a/tests/Issues/DowngradeNamedTrailing/Fixture/fixture.php.inc b/tests/Issues/DowngradeNamedTrailing/Fixture/fixture.php.inc new file mode 100644 index 00000000..7783f706 --- /dev/null +++ b/tests/Issues/DowngradeNamedTrailing/Fixture/fixture.php.inc @@ -0,0 +1,53 @@ +setData($data); + } +} + +$contents = new Fixture( + $content->getType(), + id: $content->getId(), + data: ['error' => $e->getMessage()] +); + +?> +----- +setData($data); + } +} + +$contents = new Fixture( + $content->getType(), + ['error' => $e->getMessage()], + $content->getId() +); + +?> diff --git a/tests/Issues/DowngradeNamedTrailing/config/configured_rule.php b/tests/Issues/DowngradeNamedTrailing/config/configured_rule.php new file mode 100644 index 00000000..6a478268 --- /dev/null +++ b/tests/Issues/DowngradeNamedTrailing/config/configured_rule.php @@ -0,0 +1,10 @@ +withRules([DowngradeNamedArgumentRector::class, DowngradeTrailingCommasInFunctionCallsRector::class]);