From a190cf9981d62f5e23758313f276380c01f17a21 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sun, 8 Dec 2024 18:12:02 +0100 Subject: [PATCH 1/2] add rule counters --- resources/views/homepage/find_rule.blade.php | 4 ++-- .../views/livewire/find-rule-component.blade.php | 14 ++++++++++++-- src/Controller/FindRuleController.php | 7 +++++++ src/FileSystem/RectorFinder.php | 5 +++++ 4 files changed, 26 insertions(+), 4 deletions(-) diff --git a/resources/views/homepage/find_rule.blade.php b/resources/views/homepage/find_rule.blade.php index 26fbecec9..09e3720f1 100644 --- a/resources/views/homepage/find_rule.blade.php +++ b/resources/views/homepage/find_rule.blade.php @@ -6,8 +6,8 @@ @section('main')
-

- Find the best Rector rule to solve your problem +

+ Find the best Rector rule to solve your problem. Searching through {{ $ruleCount }} rules.

@livewire('find-rule-component') diff --git a/resources/views/livewire/find-rule-component.blade.php b/resources/views/livewire/find-rule-component.blade.php index 2ba0e10ca..7f164b755 100644 --- a/resources/views/livewire/find-rule-component.blade.php +++ b/resources/views/livewire/find-rule-component.blade.php @@ -68,9 +68,17 @@ class="form-select ms-3"
-
- @if ($isFilterActive) +

+ @if ($filteredRules === 0) + No rule found. Try changing group to more generic one, or use different query. + @elseif (count($filteredRules) === 1) + Found 1 rule. That's the one: + @else + Found {{ count($filteredRules) }} rules: + @endif +

+ @foreach ($filteredRules as $filteredRule)
{{ $filteredRule->getDiffCodeSample() }}

No rules found. Try different query.

@endif @else +
+

Not sure how to search? Try one of these for a start:

    diff --git a/src/Controller/FindRuleController.php b/src/Controller/FindRuleController.php index ce9f245b2..eb0e39d68 100644 --- a/src/Controller/FindRuleController.php +++ b/src/Controller/FindRuleController.php @@ -4,15 +4,22 @@ namespace App\Controller; +use App\FileSystem\RectorFinder; use Illuminate\Contracts\View\View; use Illuminate\Routing\Controller; final class FindRuleController extends Controller { + public function __construct( + private RectorFinder $rectorFinder + ) { + } + public function __invoke(): View { return \view('homepage/find_rule', [ 'page_title' => 'Find the best Rule', + 'ruleCount' => $this->rectorFinder->getRuleCount(), ]); } } diff --git a/src/FileSystem/RectorFinder.php b/src/FileSystem/RectorFinder.php index d3a573380..5329566ee 100644 --- a/src/FileSystem/RectorFinder.php +++ b/src/FileSystem/RectorFinder.php @@ -166,4 +166,9 @@ private function findInDirectoriesAndCreateRuleMetadatas(array $directories, arr return $ruleMetadatas; } + + public function getRuleCount(): int + { + return count($this->findCore()) + count($this->findCommunity()); + } } From 60618a95ee8fecb562594daa0bc7251314545de5 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sun, 8 Dec 2024 18:14:53 +0100 Subject: [PATCH 2/2] remove play and learn from menu, make items more focusd --- resources/views/_snippets/menu_items.blade.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/resources/views/_snippets/menu_items.blade.php b/resources/views/_snippets/menu_items.blade.php index 33ecd4ea9..c8ce92e92 100644 --- a/resources/views/_snippets/menu_items.blade.php +++ b/resources/views/_snippets/menu_items.blade.php @@ -18,16 +18,6 @@ class="nav-link">Find Rule @endif - -