Skip to content

Commit 4bbf30b

Browse files
committed
remove local save stub and audit cleanups
1 parent e8fe386 commit 4bbf30b

9 files changed

Lines changed: 13 additions & 25 deletions

File tree

bun.lock

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@
8888
"yauzl": "^3.3.0",
8989
"yazl": "3.3.1"
9090
},
91+
"overrides": {
92+
"@xmldom/xmldom": "0.8.13"
93+
},
9194
"engines": {
9295
"node": ">= 16.6.0"
9396
},

src/exports.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ export type {
1414
UploadOptions,
1515
Version,
1616
} from './types';
17-
export { question, saveToLocal } from './utils';
17+
export { question } from './utils';

src/package.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import fs from 'fs-extra';
1+
import * as fs from 'fs-extra';
22
import os from 'os';
33
import path from 'path';
44
import Table from 'tty-table';
@@ -11,7 +11,6 @@ import {
1111
getAppInfo,
1212
getIpaInfo,
1313
question,
14-
saveToLocal,
1514
} from './utils';
1615
import { AabParser } from './utils/app-info-parser/aab';
1716
import { depVersions } from './utils/dep-versions';
@@ -129,7 +128,6 @@ async function uploadNativePackage(
129128
deps: depVersions,
130129
commit: await getCommitInfo(),
131130
});
132-
saveToLocal(filePath, `${appId}/package/${id}${config.extension}`);
133131
console.log(
134132
t(config.successKey, {
135133
id,

src/utils/app-info-parser/aab.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { spawn } from 'child_process';
2-
import fs from 'fs-extra';
2+
import * as fs from 'fs-extra';
33
import os from 'os';
44
import path from 'path';
55
import { open as openZipFile } from 'yauzl';

src/utils/index.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import chalk from 'chalk';
22
import { satisfies } from 'compare-versions';
3-
import fs from 'fs-extra';
4-
import os from 'os';
53
import path from 'path';
64
import type { Root as ProtobufRoot } from 'protobufjs';
75
import { read } from 'read';
@@ -10,7 +8,7 @@ import pkg from '../../package.json';
108
import latestVersion from '../utils/latest-version';
119
import AppInfoParser from './app-info-parser';
1210
import { checkPlugins } from './check-plugin';
13-
import { IS_CRESC, tempDir } from './constants';
11+
import { IS_CRESC } from './constants';
1412
import { depVersions } from './dep-versions';
1513
import { t } from './i18n';
1614

@@ -401,15 +399,6 @@ async function resolveResource(
401399
return null;
402400
}
403401

404-
const localDir = path.resolve(os.homedir(), tempDir);
405-
fs.ensureDirSync(localDir);
406-
export function saveToLocal(_originPath: string, _destName: string) {
407-
// TODO
408-
// const destPath = path.join(localDir, destName);
409-
// fs.ensureDirSync(path.dirname(destPath));
410-
// fs.copyFileSync(originPath, destPath);
411-
}
412-
413402
async function getLatestVersion(pkgNames: string[]) {
414403
return latestVersion(pkgNames, {
415404
// useCache: true,

src/utils/plugin-config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import fs from 'fs-extra';
1+
import * as fs from 'fs-extra';
22

33
interface PluginConfig {
44
name: string;

src/versions.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { doDelete, get, getAllPackages, post, put, uploadFile } from './api';
55
import { getPlatform, getSelectedApp } from './app';
66
import { choosePackage } from './package';
77
import type { Package, Platform, Version } from './types';
8-
import { question, saveToLocal } from './utils';
8+
import { question } from './utils';
99
import { depVersions } from './utils/dep-versions';
1010
import { getCommitInfo } from './utils/git';
1111
import { t } from './utils/i18n';
@@ -433,8 +433,6 @@ export const versionCommands = {
433433
deps: depVersions,
434434
commit: await getCommitInfo(),
435435
});
436-
// TODO local diff
437-
saveToLocal(fn, `${appId}/ppk/${id}.ppk`);
438436
console.log(t('packageUploadSuccess', { id }));
439437

440438
const {

tests/versions.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ describe('versionCommands.publish', () => {
106106
let uploadFileSpy: ReturnType<typeof spyOn>;
107107
let postSpy: ReturnType<typeof spyOn>;
108108
let questionSpy: ReturnType<typeof spyOn>;
109-
let saveToLocalSpy: ReturnType<typeof spyOn>;
110109
let getCommitInfoSpy: ReturnType<typeof spyOn>;
111110
let updateSpy: ReturnType<typeof spyOn>;
112111

@@ -126,7 +125,6 @@ describe('versionCommands.publish', () => {
126125
const answers = ['name', 'description', '{}', 'y'];
127126
const questionMock = mock(async () => answers.shift() ?? '');
128127
questionSpy = spyOn(utils, 'question').mockImplementation(questionMock);
129-
saveToLocalSpy = spyOn(utils, 'saveToLocal').mockImplementation(() => {});
130128
getCommitInfoSpy = spyOn(git, 'getCommitInfo').mockResolvedValue(undefined);
131129
updateSpy = spyOn(versionCommands, 'update').mockResolvedValue(undefined);
132130
});
@@ -138,7 +136,6 @@ describe('versionCommands.publish', () => {
138136
uploadFileSpy.mockRestore();
139137
postSpy.mockRestore();
140138
questionSpy.mockRestore();
141-
saveToLocalSpy.mockRestore();
142139
getCommitInfoSpy.mockRestore();
143140
updateSpy.mockRestore();
144141
});

0 commit comments

Comments
 (0)