Restore package version bound semantics

Author: sunnylqm

src/versions.ts

@@ -569,26 +569,25 @@ export const versionCommands = {
 
     let pkgsToBind: Package[] = [];
 
-    if (minPkgVersion || maxPkgVersion) {
-      minPkgVersion = minPkgVersion ? String(minPkgVersion).trim() : undefined;
-      maxPkgVersion = maxPkgVersion ? String(maxPkgVersion).trim() : undefined;
+    if (minPkgVersion) {
+      minPkgVersion = String(minPkgVersion).trim();
+      pkgsToBind = allPkgs.filter((pkg: Package) =>
+        compare(pkg.name, minPkgVersion!, '>='),
+      );
+      if (pkgsToBind.length === 0) {
+        throw new Error(
+          t('nativeVersionNotFoundGte', { version: minPkgVersion }),
+        );
+      }
+    } else if (maxPkgVersion) {
+      maxPkgVersion = String(maxPkgVersion).trim();
       pkgsToBind = allPkgs.filter((pkg: Package) => {
-        if (minPkgVersion && !compare(pkg.name, minPkgVersion, '>=')) {
-          return false;
-        }
-        if (maxPkgVersion && !compare(pkg.name, maxPkgVersion, '<=')) {
-          return false;
-        }
-        return true;
+        return compare(pkg.name, maxPkgVersion!, '<=');
       });
       if (pkgsToBind.length === 0) {
-        const range = [
-          minPkgVersion && `>=${minPkgVersion}`,
-          maxPkgVersion && `<=${maxPkgVersion}`,
-        ]
-          .filter(Boolean)
-          .join(' ');
-        throw new Error(t('nativeVersionNotFoundMatch', { version: range }));
+        throw new Error(
+          t('nativeVersionNotFoundLte', { version: maxPkgVersion }),
+        );
       }
     } else if (pkgVersion) {
       pkgVersion = pkgVersion.trim();

tests/versions.test.ts

@@ -250,23 +250,22 @@ describe('versionCommands.update package range selection', () => {
     postSpy.mockRestore();
   });
 
-  test('applies minPackageVersion and maxPackageVersion together', async () => {
-    const appId = 'range-app';
+  test('applies minPackageVersion as a lower bound', async () => {
+    const appId = 'min-app';
 
     await versionCommands.update({
       options: {
         appId,
         versionId: '200',
         minPackageVersion: '1.1.0',
-        maxPackageVersion: '1.2.0',
       },
     });
 
     const bindingCalls = postSpy.mock.calls.filter(
       ([url]) => url === `/app/${appId}/binding`,
     );
 
-    expect(bindingCalls).toHaveLength(2);
+    expect(bindingCalls).toHaveLength(3);
     expect(bindingCalls[0]).toEqual([
       `/app/${appId}/binding`,
       {
@@ -283,6 +282,56 @@ describe('versionCommands.update package range selection', () => {
         packageId: '12',
       },
     ]);
+    expect(bindingCalls[2]).toEqual([
+      `/app/${appId}/binding`,
+      {
+        versionId: '200',
+        rollout: undefined,
+        packageId: '13',
+      },
+    ]);
+  });
+
+  test('applies maxPackageVersion as an upper bound', async () => {
+    const appId = 'max-app';
+
+    await versionCommands.update({
+      options: {
+        appId,
+        versionId: '200',
+        maxPackageVersion: '1.2.0',
+      },
+    });
+
+    const bindingCalls = postSpy.mock.calls.filter(
+      ([url]) => url === `/app/${appId}/binding`,
+    );
+
+    expect(bindingCalls).toHaveLength(3);
+    expect(bindingCalls[0]).toEqual([
+      `/app/${appId}/binding`,
+      {
+        versionId: '200',
+        rollout: undefined,
+        packageId: '10',
+      },
+    ]);
+    expect(bindingCalls[1]).toEqual([
+      `/app/${appId}/binding`,
+      {
+        versionId: '200',
+        rollout: undefined,
+        packageId: '11',
+      },
+    ]);
+    expect(bindingCalls[2]).toEqual([
+      `/app/${appId}/binding`,
+      {
+        versionId: '200',
+        rollout: undefined,
+        packageId: '12',
+      },
+    ]);
   });
 
   test('fails instead of prompting for package id in non-interactive mode', async () => {