Merge pull request #678 from reactjs/webpack-ujs

refactor(UJS) make it webpack-friendly

Author: rmosolgo

.gitignore

@@ -2,9 +2,10 @@
 Gemfile.lock
 *.log
 test/dummy/tmp
+test/dummy/public/packs
 gemfiles/*.lock
 *.swp
 /vendor/react
-react-builds/node_modules
+**/node_modules
 react-builds/build
 coverage/

.travis.yml

@@ -1,7 +1,9 @@
 language: ruby
 sudo: required
 dist: trusty
-cache: bundler
+cache:
+  bundler: true
+  yarn: true
 rvm:
   - 2.3.0
   - 2.1
@@ -60,3 +62,8 @@ before_install:
   - tar -xvf $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis-phantomjs
   - export PATH=$PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH
   - phantomjs --version
+  # Repo for Yarn
+  - sudo apt-key adv --fetch-keys http://dl.yarnpkg.com/debian/pubkey.gpg
+  - echo "deb http://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
+  - sudo apt-get update -qq
+  - sudo apt-get install -y -qq yarn

Appraisals

@@ -43,11 +43,13 @@ appraise "rails-4.2-sprockets_4" do
   gem 'rails', '~> 4.2.1'
   gem "sprockets", "~> 4.0.x"
   gem "turbolinks", "~> 2.5.0"
+  gem "webpacker", github: "rails/webpacker"
 end
 
 appraise "rails-5" do
   gem 'rails', '~> 5.0.0'
   gem "turbolinks", "~> 5.0.0"
+  gem "webpacker", github: "rails/webpacker"
 end
 
 appraise "rails-5-no_sprockets" do

Rakefile

@@ -12,15 +12,20 @@ def copy_react_asset(webpack_file, destination_file)
   FileUtils.cp(full_webpack_path, full_destination_path)
 end
 
+# Move to `dirname` and execute `yarn {cmd}`
+def yarn_run_in(dirname, cmd)
+  Dir.chdir(dirname) do
+    `yarn #{cmd}`
+  end
+end
+
 namespace :react do
   desc "Run the JS build process to put files in the gem source"
   task update: [:install, :build, :copy]
 
   desc "Build the JS bundles with Webpack"
   task :build do
-    Dir.chdir("react-builds") do
-      `yarn run build`
-    end
+    yarn_run_in("react-builds", "build")
   end
 
   desc "Copy browser-ready JS files to the gem's asset paths"
@@ -39,8 +44,36 @@ namespace :react do
 
   desc "Install the JavaScript dependencies"
   task :install do
-    Dir.chdir("react-builds") do
-      `yarn upgrade`
+    yarn_run_in("react-builds", "upgrade")
+  end
+end
+
+namespace :ujs do
+  desc "Run the JS build process to put files in the gem source"
+  task update: [:install, :build, :copy]
+
+  desc "Install the JavaScript dependencies"
+  task :install do
+    yarn_run_in("react_ujs", "upgrade")
+  end
+
+
+  desc "Build the JS bundles with Webpack"
+  task :build do
+    yarn_run_in("react_ujs", "build")
+  end
+
+  desc "Copy browser-ready JS files to the gem's asset paths"
+  task :copy do
+    full_webpack_path = File.expand_path("../react_ujs/dist/react_ujs.js", __FILE__)
+    full_destination_path = File.expand_path("../lib/assets/javascripts/react_ujs.js", __FILE__)
+    FileUtils.cp(full_webpack_path, full_destination_path)
+  end
+
+  desc "Publish the package in ./react_ujs/ to npm as `react_ujs`"
+  task :publish do
+    Dir.chdir("react_ujs") do
+      `npm publish`
     end
   end
 end
@@ -57,3 +90,11 @@ Rake::TestTask.new(:test) do |t|
 end
 
 task default: :test
+
+task :test_setup do
+  Dir.chdir("./test/dummy") do
+    `yarn install`
+  end
+end
+
+task test: :test_setup

gemfiles/rails_4.2_sprockets_4.gemfile

@@ -5,5 +5,6 @@ source "http://rubygems.org"
 gem "rails", "~> 4.2.1"
 gem "sprockets", "~> 4.0.x"
 gem "turbolinks", "~> 2.5.0"
+gem "webpacker", :github => "rails/webpacker"
 
 gemspec :path => "../"

gemfiles/rails_5.gemfile

@@ -4,5 +4,6 @@ source "http://rubygems.org"
 
 gem "rails", "~> 5.0.0"
 gem "turbolinks", "~> 5.0.0"
+gem "webpacker", :github => "rails/webpacker"
 
 gemspec :path => "../"