remove the wrapper as well

robrobbins · robrobbins · commit 9bc5194f66df · 2015-01-27T09:40:22.000-07:00
diff --git a/lib/assets/javascripts/react_ujs_p.js b/lib/assets/javascripts/react_ujs_p.js
@@ -46,9 +46,11 @@
       var nodes = React.ujs.findDOMNodes();
       
       for (var i = 0; i < nodes.length; ++i) {
+        var node = nodes[i];
         
-        React.unmountComponentAtNode(nodes[i]);
-        
+        React.unmountComponentAtNode(node);
+        // now remove the `data-react-class` wrapper as well
+        node.parentElement && node.parentElement.removeChild(node);
       }
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,11 @@`
`46`	`46`	`var nodes = React.ujs.findDOMNodes();`
`47`	`47`
`48`	`48`	`for (var i = 0; i < nodes.length; ++i) {`
	`49`	`+ var node = nodes[i];`
`49`	`50`
`50`		`- React.unmountComponentAtNode(nodes[i]);`
`51`		`-`
	`51`	`+ React.unmountComponentAtNode(node);`
	`52`	+ // now remove the `data-react-class` wrapper as well
	`53`	`+ node.parentElement && node.parentElement.removeChild(node);`
`52`	`54`	`}`
`53`	`55`	`}`
`54`	`56`	`};`