Turns out _no_sprockets_ name is actually executable code...

BookOfGreg · BookOfGreg · commit 8c88a3b668e7 · 2017-09-11T11:27:40.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -12,10 +12,10 @@ rvm:
 gemfile:
   # These have webpacker:
   - gemfiles/rails_4.2_sprockets_4.gemfile
-  - gemfiles/rails_5_webpacker_1_1.gemfile
-  - gemfiles/rails_5_webpacker_1_x.gemfile
-  - gemfiles/rails_5_webpacker_2.gemfile
-  - gemfiles/rails_5_webpacker_3.gemfile
+  - gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile
+  - gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
+  - gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
+  - gemfiles/rails_5_no_sprockets_webpacker_3.gemfile
   # These don't have webpacker:
   - gemfiles/rails_3.2.gemfile
   - gemfiles/rails_4.0.5.gemfile
@@ -42,13 +42,13 @@ matrix:
     - rvm: 2.1
       gemfile: gemfiles/rails_4.2_sprockets_4.gemfile
     - rvm: 2.1
-      gemfile: gemfiles/rails_5_webpacker_1_1.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile
     - rvm: 2.1
-      gemfile: gemfiles/rails_5_webpacker_1_x.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
     - rvm: 2.1
-      gemfile: gemfiles/rails_5_webpacker_2.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
     - rvm: 2.1
-      gemfile: gemfiles/rails_5_webpacker_3.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_3.gemfile
     - rvm: 2.1
       gemfile: gemfiles/rails_5.1_sprockets_4.gemfile
     - rvm: jruby-9.0.1.0
@@ -60,13 +60,13 @@ matrix:
     - rvm: jruby-9.0.1.0
       gemfile: gemfiles/rails_4.2_sprockets_2.gemfile
     - rvm: jruby-9.0.1.0
-      gemfile: gemfiles/rails_5_webpacker_1_1.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile
     - rvm: jruby-9.0.1.0
-      gemfile: gemfiles/rails_5_webpacker_1_x.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
     - rvm: jruby-9.0.1.0
-      gemfile: gemfiles/rails_5_webpacker_2.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
     - rvm: jruby-9.0.1.0
-      gemfile: gemfiles/rails_5_webpacker_3.gemfile
+      gemfile: gemfiles/rails_5_no_sprockets_webpacker_3.gemfile
     - rvm: jruby-9.0.1.0
       gemfile: gemfiles/rails_5_no_sprockets.gemfile
 
diff --git a/Appraisals b/Appraisals
@@ -48,31 +48,33 @@ appraise "rails-4.2-sprockets_4" do
   gem "mini_racer"
 end
 
-appraise "rails-5_webpacker_1_1" do
+# no_sprockets is a magical name from sprockets_helper.rb in test to
+#   load in certain tests or not.
+appraise "rails-5_no_sprockets_webpacker_1_1" do
   gem 'rails', '~> 5.0.0'
   gem "webpacker", '~> 1.1.0'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
   gem "therubyracer"
 end
 
-appraise "rails-5_webpacker_1_x" do
+appraise "rails-5_no_sprockets_webpacker_1_x" do
   gem 'rails', '~> 5.0.0'
   gem "webpacker", '~> 1.2'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
   gem "therubyracer"
 end
 
-appraise "rails-5_webpacker_2" do
+appraise "rails-5_no_sprockets_webpacker_2" do
   gem 'rails', '~> 5.0.0'
   gem "webpacker", '~> 2.0'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
   gem "therubyracer"
 end
 
-appraise "rails-5_webpacker_3" do
+appraise "rails-5_no_sprockets_webpacker_3" do
   gem 'rails', '~> 5.0.0'
   gem 'webpacker', '>= 3.0'
   # This ExecJS backend provides stateful context
diff --git a/Gemfile b/Gemfile
@@ -2,4 +2,3 @@ source 'http://rubygems.org'
 
 gemspec
 # This is an optional dev-dependency, required whenever sprockets is required
-gem "turbolinks"
diff --git a/gemfiles/rails_3.2.gemfile b/gemfiles/rails_3.2.gemfile
@@ -2,8 +2,8 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks", "~> 2.0"
 gem "rails", "~> 3.2.21"
 gem "rack-cache", "~> 1.6.1"
+gem "turbolinks", "~> 2.0"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4.0.5.gemfile b/gemfiles/rails_4.0.5.gemfile
@@ -2,7 +2,7 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks"
 gem "rails", "4.0.5"
+gem "turbolinks"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4.0_with_therubyracer.gemfile b/gemfiles/rails_4.0_with_therubyracer.gemfile
@@ -2,8 +2,8 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks"
 gem "rails", "~> 4.0.13"
 gem "therubyracer", "0.12.0", :platform => :mri
+gem "turbolinks"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4.1.gemfile b/gemfiles/rails_4.1.gemfile
@@ -2,7 +2,7 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks", "~> 2.3.0"
 gem "rails", "~> 4.1.10"
+gem "turbolinks", "~> 2.3.0"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4.2_sprockets_2.gemfile b/gemfiles/rails_4.2_sprockets_2.gemfile
@@ -2,8 +2,8 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks"
 gem "rails", "~> 4.2.1"
 gem "sprockets", "~> 2.12"
+gem "turbolinks"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4.2_sprockets_3.gemfile b/gemfiles/rails_4.2_sprockets_3.gemfile
@@ -2,8 +2,8 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks", "~> 2.5.0"
 gem "rails", "~> 4.2.1"
 gem "sprockets", "~> 3.5"
+gem "turbolinks", "~> 2.5.0"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4.2_sprockets_4.gemfile b/gemfiles/rails_4.2_sprockets_4.gemfile
@@ -2,9 +2,9 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks", "~> 2.5.0"
 gem "rails", "~> 4.2.1"
 gem "sprockets", "~> 4.0.x"
+gem "turbolinks", "~> 2.5.0"
 gem "mini_racer"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_5.1_sprockets_4.gemfile b/gemfiles/rails_5.1_sprockets_4.gemfile
@@ -2,8 +2,8 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks", "~> 5.0.0"
 gem "rails", "~> 5.1"
 gem "sprockets", "~> 4.0.x"
+gem "turbolinks", "~> 5.0.0"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_5_no_sprockets.gemfile b/gemfiles/rails_5_no_sprockets.gemfile
@@ -2,7 +2,6 @@
 
 source "http://rubygems.org"
 
-gem "turbolinks"
 gem "rails", "~> 5.0.0"
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile b/gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile
@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+gem "webpacker", "~> 1.1.0"
+gem "therubyracer"
+
+gemspec :path => "../"
diff --git a/gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile b/gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+gem "webpacker", "~> 1.2"
+gem "therubyracer"
+
+gemspec :path => "../"
diff --git a/gemfiles/rails_5_no_sprockets_webpacker_2.gemfile b/gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+gem "webpacker", "~> 2.0"
+gem "therubyracer"
+
+gemspec :path => "../"
diff --git a/gemfiles/rails_5_no_sprockets_webpacker_3.gemfile b/gemfiles/rails_5_no_sprockets_webpacker_3.gemfile
@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 5.0.0"
+gem "webpacker", ">= 3.0"
+gem "therubyracer"
+
+gemspec :path => "../"
diff --git a/test/support/sprockets_helpers.rb b/test/support/sprockets_helpers.rb
@@ -1,6 +1,11 @@
 module SprocketsHelpers
   module_function
   def available?
+    # We can't scan for sprockets in gemfile_lock because it's
+    #   a dependency of Rails even if not required.
+    # We also can't scan for defined?(Sprockets) because this is used to
+    #   require Sprockets in the config/application.rb
+    # !!Bundler.locked_gems.specs.find {|gem_spec| gem_spec.name == 'sprockets'}
     ENV["BUNDLE_GEMFILE"] !~ /no_sprockets/
   end
 

Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,3 @@ source 'http://rubygems.org'`
`2`	`2`
`3`	`3`	`gemspec`
`4`	`4`	`# This is an optional dev-dependency, required whenever sprockets is required`
`5`		`-gem "turbolinks"`