Define methods based on which webpacker version is loaded to make controlling support easier and more obvious

Author: BookOfGreg

lib/react/server_rendering/webpacker_manifest_container.rb

@@ -1,4 +1,5 @@
 require "open-uri"
+require 'pry'
 
 module React
   module ServerRendering
@@ -7,9 +8,16 @@ module ServerRendering
     # - webpack-dev-server
     # - compiled pack
     class WebpackerManifestContainer
+
+      MAJOR, MINOR, PATCH, _ = Bundler.locked_gems.specs.find {|gem_spec| gem_spec.name == 'webpacker'}.version.segments
+
       # This pattern matches the code that initializes the dev-server client.
       CLIENT_REQUIRE = %r{__webpack_require__\(.*webpack-dev-server\/client\/index\.js.*\n}
 
+      def self.compatible?
+        !!defined?(Webpacker)
+      end
+
       def find_asset(logical_path)
         # raises if not found
         asset_path = manifest.lookup(logical_path).to_s
@@ -26,26 +34,44 @@ def find_asset(logical_path)
         end
       end
 
-      def manifest
-        Webpacker.respond_to?(:manifest) ? Webpacker.manifest : Webpacker::Manifest
+      if MAJOR < 3
+        def manifest
+          Webpacker::Manifest
+        end
+      else
+        def manifest
+          Webpacker.manifest
+        end
       end
 
-      def file_path path
-        manifest.respond_to?(:lookup_path) ? manifest.lookup_path(path) : File.join(output_path, manifest.lookup(path).split('/')[2..-1])
+      if MAJOR < 3
+        def config
+          Webpacker::Configuration
+        end
+      else
+        def config
+          Webpacker.config
+        end
       end
 
-      def config
-        Webpacker.respond_to?(:config) ? Webpacker.config : Webpacker::Configuration
+      if (MAJOR == 1 && MINOR >= 2) || MAJOR == 2
+        def file_path path
+          manifest.lookup_path(path)
+        end
+      elsif MAJOR == 3
+        def file_path path
+          File.join(Webpacker.config.public_output_path, path)
+        end
+      else # 1.0 and 1.1 support
+        def file_path path
+          File.join(output_path, manifest.lookup(path).split('/')[2..-1])
+        end
       end
 
       def output_path
         # Webpack1 /:output/:entry, Webpack3 /public/:output
         config.respond_to?(:output_path) ? config.output_path : 'public'
       end
-
-      def self.compatible?
-        !!defined?(Webpacker)
-      end
     end
   end
 end

test/dummy_webpacker3/package.json

@@ -1,5 +1,6 @@
 {
   "dependencies": {
+    "@rails/webpacker": "^3.0.1",
     "autoprefixer": "^7.1.1",
     "babel-core": "^6.24.1",
     "babel-loader": "7.x",
@@ -32,6 +33,6 @@
     "webpack-merge": "^4.1.0"
   },
   "devDependencies": {
-    "webpack-dev-server": "^2.4.5"
+    "webpack-dev-server": "^2.7.1"
   }
 }